Re: [PATCH net 3/9] virtio-net: fix page miscount during XDP linearizing

From	Jason Wang <jasowang@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net 3/9] virtio-net: fix page miscount during XDP linearizing
Date	2016-12-26 03:40 +0100
Message-ID	<sStmF-6Cc-7@gated-at.bofh.it> (permalink)
References	<sRzaN-833-3@gated-at.bofh.it> <sRzaO-833-19@gated-at.bofh.it> <sRAqe-kn-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2016年12月23日 23:54, John Fastabend wrote:
> On 16-12-23 06:37 AM, Jason Wang wrote:
>> We don't put page during linearizing, the would cause leaking when
>> xmit through XDP_TX or the packet exceeds PAGE_SIZE. Fix them by
>> put page accordingly. Also decrease the number of buffers during
>> linearizing to make sure caller can free buffers correctly when packet
>> exceeds PAGE_SIZE. With this patch, we won't get OOM after linearize
>> huge number of packets.
>>
>> Cc: John Fastabend <john.r.fastabend@intel.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
> Thanks! looks good. By the way do you happen to have any actual
> configuration where this path is hit? I obviously didn't test this
> very long other than a quick test with my hacked vhost driver.
>
> Acked-by: John Fastabend <john.r.fastabend@intel.com>

Yes, I have. Just increase the MTU above 1500 for both virtio and tap 
and produce some traffic with size which will lead underestimated of rxbuf.

Thanks

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net 3/9] virtio-net: fix page miscount during XDP linearizing Jason Wang <jasowang@redhat.com> - 2016-12-23 15:40 +0100
  Re: [PATCH net 3/9] virtio-net: fix page miscount during XDP  linearizing John Fastabend <john.fastabend@gmail.com> - 2016-12-23 17:00 +0100
    Re: [PATCH net 3/9] virtio-net: fix page miscount during XDP  linearizing Jason Wang <jasowang@redhat.com> - 2016-12-26 03:40 +0100

csiph-web