Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1547223

Re: [PATCHv4 2/8] Fixed variables not being consistently lower case

Show all headers | View raw

On 25 December 2016 20:14:09 GMT+00:00, Al Viro <viro@ZenIV.linux.org.uk> wrote:
>On Sun, Dec 25, 2016 at 01:41:06PM -0600, Scott Matheina wrote:
>> Across the file, variables were sometimes upper case, some times
>> lower case, this fix addresses a few of the instances with this
>> inconsistency.
>
>NAK.  Go learn C and don't come back until you've done that.  If
>somebody
>has told you that you can contribute without knowing the language,
>they'd
>lied - you really can't.  And I would *STRONGLY* recommend to stay away
>from drivers/staging while you are learning C - it's like trying to use
>a public restroom wall as a sex-ed textbook.

Please can we keep things polite.

Jonathan
>
>While we are at it, it might be a good idea to check if the kernel
>builds after your changes and see what errors are produced.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv4 0/8] Checkpatch fixes to driver/staging/iio/addac Scott Matheina <scott@matheina.com> - 2016-12-25 20:50 +0100
  [PATCHv4 3/8] Fix camel case issues Scott Matheina <scott@matheina.com> - 2016-12-25 20:50 +0100
  [PATCHv4 2/8] Fixed variables not being consistently lower case Scott Matheina <scott@matheina.com> - 2016-12-25 20:50 +0100
    Re: [PATCHv4 2/8] Fixed variables not being consistently lower case Al Viro <viro@ZenIV.linux.org.uk> - 2016-12-25 21:20 +0100
      Re: [PATCHv4 2/8] Fixed variables not being consistently lower case Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2016-12-25 23:40 +0100
        Re: [PATCHv4 2/8] Fixed variables not being consistently lower case Al Viro <viro@ZenIV.linux.org.uk> - 2016-12-26 01:20 +0100
  [PATCHv4 1/8] fixed long description text exceeding 80 characters Scott Matheina <scott@matheina.com> - 2016-12-25 20:50 +0100

csiph-web