Re: [PATCH] PCI: exynos: refactor exynos pcie driver

From	Jaehoon Chung <jh80.chung@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PCI: exynos: refactor exynos pcie driver
Date	2016-12-27 11:20 +0100
Message-ID	<sSX1o-Js-5@gated-at.bofh.it> (permalink)
References	(3 earlier) <sSAet-3a2-3@gated-at.bofh.it> <sSOr8-3OI-3@gated-at.bofh.it> <sSPwR-4qF-11@gated-at.bofh.it> <sSPQd-4wp-1@gated-at.bofh.it> <sSTAu-6XK-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Dear Alim,

On 12/27/2016 03:34 PM, Alim Akhtar wrote:
> Hi Jaehoon,
> 
[snip]
>>
>> Ah. Right..And i'm doing the refactoring to reuse the current pci-exynos.c.
> There is a nice refactoring patch posted by Pankaj recently @
> https://lkml.org/lkml/2016/12/23/73
> I would suggest you to rebase your work on this top.

Well, i don't think so. Pankaj's patch might be good way..but i can't agree about a few point.
If based on Pankaj's patch, it's more complex..

why put the ops callback for getting clock and mem resource?

If PHY generic framework is used, it's unnecessary. because it needs to get elbi and dbi resources.
clock resources("pcie" and "pcie_bus") are general things.

If Pankaj's patch is applied, also need to make the exynos5433_pcie_* callback functions?
It doesn't make sense.

I want to know maintainer's opinion..we can just touch a little for supporting All Exynos SoCs.

Best Regards,
Jaehoon Chung

> 
>> Maybe..Today or Tomorrow..I will send the patches..At that time, could you also check them?
>> Any comments might be helpful to me! :)
>>
> Will wait for you patches :-)
> 
>> Best Regards,
>> Jaehoon Chung
>>
[snip]

Thread

[PATCH] PCI: exynos: refactor exynos pcie driver Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-12-23 12:00 +0100
  Re: [PATCH] PCI: exynos: refactor exynos pcie driver "Jingoo Han" <jingoohan1@gmail.com> - 2016-12-23 19:40 +0100
    Re: [PATCH] PCI: exynos: refactor exynos pcie driver Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-12-27 04:40 +0100
  Re: [PATCH] PCI: exynos: refactor exynos pcie driver Krzysztof Kozlowski <krzk@kernel.org> - 2016-12-24 10:30 +0100
  Re: [PATCH] PCI: exynos: refactor exynos pcie driver Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-26 10:10 +0100
    Re: [PATCH] PCI: exynos: refactor exynos pcie driver Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-26 10:10 +0100
    Re: [PATCH] PCI: exynos: refactor exynos pcie driver Alim Akhtar <alim.akhtar@samsung.com> - 2016-12-26 11:00 +0100
      Re: [PATCH] PCI: exynos: refactor exynos pcie driver Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-27 02:10 +0100
        Re: [PATCH] PCI: exynos: refactor exynos pcie driver Alim Akhtar <alim.akhtar@samsung.com> - 2016-12-27 03:20 +0100
          Re: [PATCH] PCI: exynos: refactor exynos pcie driver Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-27 03:40 +0100
            Re: [PATCH] PCI: exynos: refactor exynos pcie driver Alim Akhtar <alim.akhtar@samsung.com> - 2016-12-27 07:40 +0100
              Re: [PATCH] PCI: exynos: refactor exynos pcie driver Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-27 11:20 +0100
                Re: [PATCH] PCI: exynos: refactor exynos pcie driver Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-12-28 04:20 +0100
                Re: [PATCH] PCI: exynos: refactor exynos pcie driver Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-28 06:40 +0100
    Re: [PATCH] PCI: exynos: refactor exynos pcie driver "Jingoo Han" <jingoohan1@gmail.com> - 2016-12-26 15:50 +0100
      Re: [PATCH] PCI: exynos: refactor exynos pcie driver Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-27 02:20 +0100
    Re: [PATCH] PCI: exynos: refactor exynos pcie driver Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-12-27 05:30 +0100
  Re: [PATCH] PCI: exynos: refactor exynos pcie driver Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-12-27 14:40 +0100
    Re: [PATCH] PCI: exynos: refactor exynos pcie driver Pankaj Dubey <pankaj.dubey@samsung.com> - 2016-12-28 04:20 +0100

csiph-web