Re: [PATCHv2] crypto: testmgr: Use heap buffer for acomp test input

Path	csiph.com!goblin1!goblin.stu.neva.ru!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2] crypto: testmgr: Use heap buffer for acomp test input
Date	Tue, 27 Dec 2016 11:10:01 +0100
Message-ID	<sSWRH-FY-7@gated-at.bofh.it> (permalink)
References	<sQVQ6-88R-11@gated-at.bofh.it>
X-Original-To	Laura Abbott <labbott@redhat.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	"David S. Miller" <davem@davemloft.net>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Giovanni Cabiddu <giovanni.cabiddu@intel.com>, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland <mark.rutland@arm.com>, Christopher Covington <cov@codeaurora.org>
X-Original-Date	Tue, 27 Dec 2016 18:06:33 +0800
X-Original-Message-ID	<20161227100633.GH10629@gondor.apana.org.au>
X-Original-References	<1482352374-22750-1-git-send-email-labbott@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1547540

Show key headers only | View raw

On Wed, Dec 21, 2016 at 12:32:54PM -0800, Laura Abbott wrote:
> 
> Christopher Covington reported a crash on aarch64 on recent Fedora
> kernels:
> 
> kernel BUG at ./include/linux/scatterlist.h:140!
> Internal error: Oops - BUG: 0 [#1] PREEMPT SMP
> Modules linked in:
> CPU: 2 PID: 752 Comm: cryptomgr_test Not tainted 4.9.0-11815-ge93b1cc #162
> Hardware name: linux,dummy-virt (DT)
> task: ffff80007c650080 task.stack: ffff800008910000
> PC is at sg_init_one+0xa0/0xb8
> LR is at sg_init_one+0x24/0xb8
> ...
> [<ffff000008398db8>] sg_init_one+0xa0/0xb8
> [<ffff000008350a44>] test_acomp+0x10c/0x438
> [<ffff000008350e20>] alg_test_comp+0xb0/0x118
> [<ffff00000834f28c>] alg_test+0x17c/0x2f0
> [<ffff00000834c6a4>] cryptomgr_test+0x44/0x50
> [<ffff0000080dac70>] kthread+0xf8/0x128
> [<ffff000008082ec0>] ret_from_fork+0x10/0x50
> 
> The test vectors used for input are part of the kernel image. These
> inputs are passed as a buffer to sg_init_one which eventually blows up
> with BUG_ON(!virt_addr_valid(buf)). On arm64, virt_addr_valid returns
> false for the kernel image since virt_to_page will not return the
> correct page. Fix this by copying the input vectors to heap buffer
> before setting up the scatterlist.
> 
> Reported-by: Christopher Covington <cov@codeaurora.org>
> Fixes: d7db7a882deb ("crypto: acomp - update testmgr with support for acomp")
> Signed-off-by: Laura Abbott <labbott@redhat.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2] crypto: testmgr: Use heap buffer for acomp test input Laura Abbott <labbott@redhat.com> - 2016-12-21 21:40 +0100
  Re: [PATCHv2] crypto: testmgr: Use heap buffer for acomp test input Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-27 11:10 +0100

csiph-web