Re: [RFC PATCH 1/7] PF driver modified to enable HW filter support, changes works in backward compatibility mode Enable required things in Makefile Enable LZ4 dependecy inside config file

From	Sunil Kovvuri <sunil.kovvuri@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/7] PF driver modified to enable HW filter support, changes works in backward compatibility mode Enable required things in Makefile Enable LZ4 dependecy inside config file
Date	2016-12-27 05:30 +0100
Message-ID	<sSRyG-5IB-9@gated-at.bofh.it> (permalink)
References	<sQNSy-3fG-25@gated-at.bofh.it> <sQOOE-3SW-91@gated-at.bofh.it> <sQOOE-3SW-89@gated-at.bofh.it> <sSErL-5SM-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>  #define NIC_MAX_RSS_HASH_BITS          8
>>  #define NIC_MAX_RSS_IDR_TBL_SIZE       (1 << NIC_MAX_RSS_HASH_BITS)
>> +#define NIC_TNS_RSS_IDR_TBL_SIZE       5
>
> So you want to use only 5 queues per VF when TNS is enabled, is it ??
> There are 4096 RSS indices in total, for each VF you can use max 32.
> I guess you wanted to set no of hash bits to 5 instead of table size.
>
> SATHA>>> We enabled 8 queues for VF. Yes Macro name misleads it has to be hash bits, will change this in next version

No, I am not referring to any discrepancy in naming the macro.
If you check your code

- hw->rss_ind_tbl_size = NIC_MAX_RSS_IDR_TBL_SIZE;
+ hw->rss_ind_tbl_size = veb_enabled ? NIC_TNS_RSS_IDR_TBL_SIZE :
+     NIC_MAX_RSS_IDR_TBL_SIZE;

You are setting RSS table size to 5, i.e RSS hash bits will be set to 2.
Hence only 4 queues (not even 5 as i mentioned earlier). Please check
'nicvf_rss_init' you will understand what i am saying.
Have you tested and observed pkts in all 8 queues ?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 1/7] PF driver modified to enable HW filter support,  changes works in backward compatibility mode Enable required things in  Makefile Enable LZ4 dependecy inside config file Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2016-12-21 14:10 +0100
  RE: [RFC PATCH 1/7] PF driver modified to enable HW filter support,  changes works in backward compatibility mode Enable required things in  Makefile Enable LZ4 dependecy inside config file "Koteshwar Rao, Satha" <Satha.Rao@cavium.com> - 2016-12-26 15:30 +0100
    Re: [RFC PATCH 1/7] PF driver modified to enable HW filter support,  changes works in backward compatibility mode Enable required things in  Makefile Enable LZ4 dependecy inside config file Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2016-12-27 05:30 +0100

csiph-web