[patch 2/2] x86/mce/AMD: Make the init code more robust

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	[patch 2/2] x86/mce/AMD: Make the init code more robust
Date	2016-12-26 23:10 +0100
Message-ID	<sSLCV-24U-7@gated-at.bofh.it> (permalink)
References	<sSLCV-24U-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

If mce_device_init() fails then the mce device pointer is NULL and the AMD
mce code happily dereferences it.

Add a sanity check.

Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/kernel/cpu/mcheck/mce_amd.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/arch/x86/kernel/cpu/mcheck/mce_amd.c
+++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c
@@ -1182,6 +1182,9 @@ static int threshold_create_bank(unsigne
 	const char *name = get_name(bank, NULL);
 	int err = 0;
 
+	if (!dev)
+		return -ENODEV;
+
 	if (is_shared_bank(bank)) {
 		nb = node_to_amd_nb(amd_get_nb_id(cpu));

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch 2/2] x86/mce/AMD: Make the init code more robust Thomas Gleixner <tglx@linutronix.de> - 2016-12-26 23:10 +0100
  Re: [patch 2/2] x86/mce/AMD: Make the init code more robust Borislav Petkov <bp@alien8.de> - 2016-12-27 08:10 +0100

csiph-web