Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1547304

Re: [PATCH v3 4/4] clk: rockchip: add new pll-type for rk3328

Show all headers | View raw

Am Montag, 26. Dezember 2016, 11:45:30 CET schrieb Elaine Zhang:
> The rk3328's pll and clock are similar with rk3036's,
> it different with pll_mode_mask, the rk3328 soc
> pll mode only one bit(rk3036 soc have two bits)
> so these should be independent and separate from
> the series of rk3328s.
> 
> Changes in v3:
>   fix up the pll type pll_rk3328 description and use
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> ---

pll-specific code looks good now, but please make this patch before the clock 
controller in the series and move the 

@@ -130,6 +152,7 @@
 enum rockchip_pll_type {
        pll_rk3036,
        pll_rk3066,
+       pll_rk3328,
        pll_rk3399,
 };
 
from patch3 into this one.


Thanks
Heiko

PS: I will have some comments for the clock controller patch, but it's xmas, 
so that may take bit still.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/4] clk: rockchip: support clk controller for rk3328 SoC Elaine Zhang <zhangqing@rock-chips.com> - 2016-12-26 04:50 +0100
  [PATCH v3 4/4] clk: rockchip: add new pll-type for rk3328 Elaine Zhang <zhangqing@rock-chips.com> - 2016-12-26 04:50 +0100
    Re: [PATCH v3 4/4] clk: rockchip: add new pll-type for rk3328 Heiko Stuebner <heiko@sntech.de> - 2016-12-26 12:20 +0100
  [PATCH v3 2/4] dt-bindings: add bindings for rk3328 clock controller Elaine Zhang <zhangqing@rock-chips.com> - 2016-12-26 04:50 +0100
    Re: [PATCH v3 2/4] dt-bindings: add bindings for rk3328 clock controller Heiko Stuebner <heiko@sntech.de> - 2016-12-26 12:20 +0100
  [PATCH v3 1/4] clk: rockchip: add dt-binding header for rk3328 Elaine Zhang <zhangqing@rock-chips.com> - 2016-12-26 04:50 +0100

csiph-web