Re: [PATCH 00/66] use permission-specific DEVICE_ATTR variants

From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 00/66] use permission-specific DEVICE_ATTR variants
Date	2016-12-23 14:10 +0100
Message-ID	<sRxLH-7js-9@gated-at.bofh.it> (permalink)
References	<sRaFr-10p-3@gated-at.bofh.it> <sRnW1-Pj-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Hi Julia,
>
> I noticed that drivers/hwmon/gl518sm.c was not converted. Running your script
> on it does not do anything. Any idea what might cause that ?

I believe that it is due to the following:

#define show(type, suffix, value)                                       \
static ssize_t show_##suffix(struct device *dev,                        \
                             struct device_attribute *attr, char *buf)  \
{                                                                       \
        struct gl518_data *data = gl518_update_device(dev);             \
        return sprintf(buf, "%d\n", type##_FROM_REG(data->value));      \
}


Coccinelle doesn't understand the relationship between this macro and the
show functions.

julia

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/66] use permission-specific DEVICE_ATTR variants Julia Lawall <Julia.Lawall@lip6.fr> - 2016-12-22 13:50 +0100
  [PATCH 02/66] hwmon: (adm1026) use permission-specific DEVICE_ATTR variants Julia Lawall <Julia.Lawall@lip6.fr> - 2016-12-22 13:50 +0100
  [PATCH 11/66] hwmon: (fschmd) use permission-specific DEVICE_ATTR variants Julia Lawall <Julia.Lawall@lip6.fr> - 2016-12-22 13:50 +0100
  [PATCH 24/66] hwmon: (lm87) use permission-specific DEVICE_ATTR variants Julia Lawall <Julia.Lawall@lip6.fr> - 2016-12-22 13:50 +0100
  [PATCH 06/66] hwmon: (adt7x10) use permission-specific DEVICE_ATTR variants Julia Lawall <Julia.Lawall@lip6.fr> - 2016-12-22 13:50 +0100
  Re: [PATCH 00/66] use permission-specific DEVICE_ATTR variants Guenter Roeck <linux@roeck-us.net> - 2016-12-23 03:40 +0100
    Re: [PATCH 00/66] use permission-specific DEVICE_ATTR variants Julia Lawall <julia.lawall@lip6.fr> - 2016-12-23 07:50 +0100
    Re: [PATCH 00/66] use permission-specific DEVICE_ATTR variants Julia Lawall <julia.lawall@lip6.fr> - 2016-12-23 14:10 +0100

csiph-web