Re: [PATCH v3 05/12] locking/ww_mutex: Remove the __ww_mutex_lock inline wrappers

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 05/12] locking/ww_mutex: Remove the __ww_mutex_lock inline wrappers
Date	2016-12-23 13:20 +0100
Message-ID	<sRwZj-6Li-7@gated-at.bofh.it> (permalink)
References	<sQU7D-70O-3@gated-at.bofh.it> <sQU7D-70O-13@gated-at.bofh.it> <sRvAd-5K8-5@gated-at.bofh.it> <sRw3f-6bO-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 23, 2016 at 12:16:03PM +0100, Nicolai Hähnle wrote:

> >For some reason this patch appears to make lib/locking-selftest.c really
> >unhappy.
> >
> >I get endless streams of:
> >
> >../lib/locking-selftest.c: In function ‘ww_test_fail_acquire’:
> >../lib/locking-selftest.c:1141:6: error: void value not ignored as it ought to be
> >  ret = WWL(&o, &t);
> >      ^
> >
> >Apparently GCC gets confused about __much_check on inline functions or
> >something, or I got the patch wrong.
> 
> Weird, I'm not getting that, and it makes no sense either from a quick
> glimpse of the code. Is there anything beside
> CONFIG_DEBUG_LOCKING_API_SELFTESTS I would have to enable to trigger this?

Not entirely sure, I'm building an allmodconfig.

> FWIW:
> 
> $ gcc --version
> gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

gcc (Debian 6.2.1-5) 6.2.1 20161124

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 05/12] locking/ww_mutex: Remove the __ww_mutex_lock inline wrappers Nicolai Hähnle <nhaehnle@gmail.com> - 2016-12-21 19:50 +0100
  Re: [PATCH v3 05/12] locking/ww_mutex: Remove the __ww_mutex_lock  inline wrappers Peter Zijlstra <peterz@infradead.org> - 2016-12-23 11:50 +0100
    Re: [PATCH v3 05/12] locking/ww_mutex: Remove the __ww_mutex_lock  inline wrappers Nicolai Hähnle <nhaehnle@gmail.com> - 2016-12-23 12:20 +0100
      Re: [PATCH v3 05/12] locking/ww_mutex: Remove the __ww_mutex_lock  inline wrappers Peter Zijlstra <peterz@infradead.org> - 2016-12-23 13:20 +0100

csiph-web