Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1546777

[PATCH] mtd: nand: xway: fix build failure

From Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] mtd: nand: xway: fix build failure
Date 2016-12-23 09:30 +0100
Message-ID <sRtoJ-4sF-7@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


The build of mips xway_defconfig was failing with the error:

drivers/mtd/nand/xway_nand.c:235:1: warning:
	data definition has no type or storage class
 MODULE_DEVICE_TABLE(of, xway_nand_match);
 ^~~~~~~~~~~~~~~~~~~
drivers/mtd/nand/xway_nand.c:235:1: error:
	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
		[-Werror=implicit-int]

It missed to include the header file.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---

Build log of next-20161223 is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/186246753

This error will be fixed but it will now uncover the next error as the
build goes on.

 drivers/mtd/nand/xway_nand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c
index 1f2948c..00168d6 100644
--- a/drivers/mtd/nand/xway_nand.c
+++ b/drivers/mtd/nand/xway_nand.c
@@ -7,6 +7,7 @@
  *  Copyright © 2016 Hauke Mehrtens <hauke@hauke-m.de>
  */
 
+#include <linux/module.h>
 #include <linux/mtd/nand.h>
 #include <linux/of_gpio.h>
 #include <linux/of_platform.h>
-- 
1.9.1

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] mtd: nand: xway: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-12-23 09:30 +0100
  Re: [PATCH] mtd: nand: xway: fix build failure Marek Vasut <marek.vasut@gmail.com> - 2016-12-23 11:10 +0100
    Re: [PATCH] mtd: nand: xway: fix build failure Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-12-29 17:30 +0100

csiph-web