Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1546706
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 0/2] power: supply: bq24735: poll register if no ac-detect gpio |
| Date | 2016-12-23 02:40 +0100 |
| Message-ID | <sRmZX-gb-3@gated-at.bofh.it> (permalink) |
| References | <sRkls-6Xd-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Hi, On Wed, Dec 21, 2016 at 10:29:51PM +0100, Peter Rosin wrote: > My patch [1] "power: supply: bq24735-charger: allow chargers to share the > ac-detect gpio" is perhaps a bit hard to digest. And while I still think > some way of sharing the ac-detect gpio is worthwhile, I thought of another > way to solve the problem at hand. Instead of polling a shared gpio, it's > as simple as polling the chip for what it is outputting on the ACOK pin. > And the code is already there! It just needs a tweak to allow this mode of > operation. > > This appears to work just fine for me, and the difference is in the noise > since my shared gpio pin happens to be on an expander on the i2c bus, so > I end up with i2c traffic for each poll either way. > > Cheers, > peda > > [1] https://lkml.org/lkml/2016/12/13/786 Thanks for your patchset. We are currently in the merge window and your patches will appear in linux-next once 4.10-rc1 has been tagged by Linus Torvalds. Until then I queued it into this branch: https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next-next -- Sebastian
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 0/2] power: supply: bq24735: poll register if no ac-detect gpio Sebastian Reichel <sre@kernel.org> - 2016-12-23 02:40 +0100
csiph-web