Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1546550

Re: [PATCH v7 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429 SoC

From Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH v7 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429 SoC
Date 2016-12-22 20:20 +0100
Message-ID <sRh4e-52z-19@gated-at.bofh.it> (permalink)
References <sRbLc-1E8-3@gated-at.bofh.it> <sRbUS-1Hh-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello,

On Thu, Dec 22, 2016 at 02:35:02PM +0100, M'boumba Cedric Madianga wrote:
> @@ -337,6 +350,16 @@
>  					slew-rate = <2>;
>  				};
>  			};
> +
> +			i2c1_pins_b: i2c1@0 {
> +				pins1 {
> +					pinmux = <STM32F429_PB9_FUNC_I2C1_SDA>;
> +					drive-open-drain;
> +				};
> +				pins2 {
> +					pinmux = <STM32F429_PB6_FUNC_I2C1_SCL>;
> +				};

the second doesn't need the open-drain property? Why?

> +			};
>  		};

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v7 0/5] Add support for the STM32F4 I2C M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-22 14:40 +0100
  [PATCH v7 5/5] ARM: configs: stm32: Add I2C support for STM32 defconfig M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-22 14:40 +0100
  [PATCH v7 4/5] ARM: dts: stm32: Add I2C1 support for STM32429 eval board M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-22 14:40 +0100
  [PATCH v7 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429 SoC M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-22 14:50 +0100
    Re: [PATCH v7 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429  SoC Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-12-22 20:20 +0100
      Re: [PATCH v7 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429 SoC "M'boumba Cedric Madianga" <cedric.madianga@gmail.com> - 2016-12-23 14:20 +0100
        Re: [PATCH v7 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429 SoC Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 10:10 +0100
          Re: [PATCH v7 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429 SoC "M'boumba Cedric Madianga" <cedric.madianga@gmail.com> - 2016-12-30 15:40 +0100
  [PATCH v7 2/5] i2c: Add STM32F4 I2C driver M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-22 14:50 +0100
    Re: [PATCH v7 2/5] i2c: Add STM32F4 I2C driver Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-12-23 10:10 +0100
      Re: [PATCH v7 2/5] i2c: Add STM32F4 I2C driver Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-12-28 22:30 +0100
        Re: [PATCH v7 2/5] i2c: Add STM32F4 I2C driver "M'boumba Cedric Madianga" <cedric.madianga@gmail.com> - 2016-12-28 23:30 +0100
          Re: [PATCH v7 2/5] i2c: Add STM32F4 I2C driver "M'boumba Cedric Madianga" <cedric.madianga@gmail.com> - 2017-01-02 14:40 +0100
  [PATCH v7 1/5] dt-bindings: Document the STM32 I2C bindings M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-12-22 14:50 +0100

csiph-web