Re: [v1] misc: cb710: core:- Handle return NULL error from pcim_iomap_table

From	arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [v1] misc: cb710: core:- Handle return NULL error from pcim_iomap_table
Date	2016-12-22 18:20 +0100
Message-ID	<sRfc6-3Sa-13@gated-at.bofh.it> (permalink)
References	<sRacp-zp-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Ignore this change. Sorry for the noise.

Thanks
Arvind


On Thursday 22 December 2016 05:28 PM, Arvind Yadav wrote:
> Here, If pcim_iomap_table will fail. It will return NULL.
> Kernel can run into a NULL-pointer dereference.
> This error check will avoid NULL pointer dereference.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>   drivers/misc/cb710/core.c |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/misc/cb710/core.c b/drivers/misc/cb710/core.c
> index fb397e7..7b60019 100644
> --- a/drivers/misc/cb710/core.c
> +++ b/drivers/misc/cb710/core.c
> @@ -248,6 +248,8 @@ static int cb710_probe(struct pci_dev *pdev,
>   	spin_lock_init(&chip->irq_lock);
>   	chip->pdev = pdev;
>   	chip->iobase = pcim_iomap_table(pdev)[0];
> +	if (!chip->iobase)
> +		return -ENOMEM;
>   
>   	pci_set_drvdata(pdev, chip);
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[v1] misc: cb710: core:- Handle return NULL error from pcim_iomap_table Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-22 13:00 +0100
  Re: [v1] misc: cb710: core:- Handle return NULL error from  pcim_iomap_table arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-22 18:20 +0100

csiph-web