Re: [v1] i2c: busses: i2c-designware-pcidrv:- Handle return NULL error from pcim_iomap_table

From	arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [v1] i2c: busses: i2c-designware-pcidrv:- Handle return NULL error from pcim_iomap_table
Date	2016-12-22 18:20 +0100
Message-ID	<sRfc5-3Sa-11@gated-at.bofh.it> (permalink)
References	<sRa2J-wg-3@gated-at.bofh.it> <sRcHg-2c2-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Yes, It will not fail. Sorry for the noise.

Thanks
-Arvind

On Thursday 22 December 2016 08:05 PM, Andy Shevchenko wrote:
> On Thu, 2016-12-22 at 17:09 +0530, Arvind Yadav wrote:
>> Here, If pcim_iomap_table will fail. It will return NULL.
>> Kernel can run into a NULL-pointer dereference.
>> This error check will avoid NULL pointer dereference.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>>   drivers/i2c/busses/i2c-designware-pcidrv.c |    4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
>> b/drivers/i2c/busses/i2c-designware-pcidrv.c
>> index d6423cf..6a1907d 100644
>> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
>> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
>> @@ -235,6 +235,10 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,
>>   	dev->controller = controller;
>>   	dev->get_clk_rate_khz = i2c_dw_get_clk_rate_khz;
>>   	dev->base = pcim_iomap_table(pdev)[0];
>> +	if (!dev->base) {
>> +		dev_err(&pdev->dev, "I/O map table allocation
>> failed\n");
>> +		return -ENOMEM;
>> +	}
> NAK.
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[v1] i2c: busses: i2c-designware-pcidrv:- Handle return NULL error from pcim_iomap_table Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-22 12:50 +0100
  Re: [v1] i2c: busses: i2c-designware-pcidrv:- Handle return NULL  error from pcim_iomap_table Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-12-22 13:00 +0100
  Re: [v1] i2c: busses: i2c-designware-pcidrv:- Handle return NULL  error from pcim_iomap_table Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-12-22 15:40 +0100
    Re: [v1] i2c: busses: i2c-designware-pcidrv:- Handle return NULL  error from pcim_iomap_table arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-22 18:20 +0100

csiph-web