Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1546441

Re: [3/3] ARM: da850: Add ti, da830-uart compatible for serial ports

From Franklin S Cooper Jr <fcooper@ti.com>
Newsgroups linux.kernel
Subject Re: [3/3] ARM: da850: Add ti, da830-uart compatible for serial ports
Date 2016-12-22 17:20 +0100
Message-ID <sReg1-3hw-5@gated-at.bofh.it> (permalink)
References <sQzcR-1Vi-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 12/20/2016 02:23 PM, David Lechner wrote:
> TI DA8xx/OMAPL13x/AM17xx/AM18xx SoCs have extra UART registers beyond

Similar comment about adding Keystone SoCs to the list of SoCs.

> the standard 8250 registers, so we need a new compatible string to
> indicate this. Also, at least one of these registers uses the full 32
> bits, so we need to specify reg-io-width in addition to reg-shift.
> 
> "ns16550a" is left in the compatible specification since it does work
> as long as the bootloader configures the SoC UART power management
> registers.
> 
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
>  arch/arm/boot/dts/da850.dtsi | 9 ++++++---

Similar changes should be made to the various Keystone dtsi files.

>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 104155d..f6cd212 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -266,22 +266,25 @@
>  			interrupt-names = "edm3_tcerrint";
>  		};
>  		serial0: serial@42000 {
> -			compatible = "ns16550a";
> +			compatible = "ti,da830-uart", "ns16550a";
>  			reg = <0x42000 0x100>;
> +			reg-io-width = <4>;
>  			reg-shift = <2>;
>  			interrupts = <25>;
>  			status = "disabled";
>  		};
>  		serial1: serial@10c000 {
> -			compatible = "ns16550a";
> +			compatible = "ti,da830-uart", "ns16550a";
>  			reg = <0x10c000 0x100>;
> +			reg-io-width = <4>;
>  			reg-shift = <2>;
>  			interrupts = <53>;
>  			status = "disabled";
>  		};
>  		serial2: serial@10d000 {
> -			compatible = "ns16550a";
> +			compatible = "ti,da830-uart", "ns16550a";
>  			reg = <0x10d000 0x100>;
> +			reg-io-width = <4>;
>  			reg-shift = <2>;
>  			interrupts = <61>;
>  			status = "disabled";
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] TI DA8xx/OMAPL13x/AM17xx/AM18xx UART David Lechner <david@lechnology.com> - 2016-12-20 21:30 +0100
  [PATCH 2/3] serial: 8250: Add new port type for TI DA8xx/OMAPL13x/AM17xx/AM18xx David Lechner <david@lechnology.com> - 2016-12-20 21:30 +0100
    Re: [2/3] serial: 8250: Add new port type for TI  DA8xx/OMAPL13x/AM17xx/AM18xx Franklin S Cooper Jr <fcooper@ti.com> - 2016-12-22 16:30 +0100
      Re: [2/3] serial: 8250: Add new port type for TI  DA8xx/OMAPL13x/AM17xx/AM18xx Franklin S Cooper Jr <fcooper@ti.com> - 2016-12-22 17:20 +0100
      Re: [2/3] serial: 8250: Add new port type for TI  DA8xx/OMAPL13x/AM17xx/AM18xx David Lechner <david@lechnology.com> - 2016-12-22 19:20 +0100
  [PATCH 1/3] doc: DT: Add ti,da830-uart to serial/8250 bindings David Lechner <david@lechnology.com> - 2016-12-20 21:30 +0100
    Re: [PATCH 1/3] doc: DT: Add ti,da830-uart to serial/8250 bindings Rob Herring <robh@kernel.org> - 2016-12-22 22:20 +0100
  [PATCH 3/3] ARM: da850: Add ti,da830-uart compatible for serial ports David Lechner <david@lechnology.com> - 2016-12-20 21:30 +0100
    Re: [3/3] ARM: da850: Add ti, da830-uart compatible for serial ports Franklin S Cooper Jr <fcooper@ti.com> - 2016-12-22 17:20 +0100
      Re: [3/3] ARM: da850: Add ti, da830-uart compatible for serial ports Sekhar Nori <nsekhar@ti.com> - 2017-01-02 09:10 +0100

csiph-web