Re: [PATCH] xen/evtchn: use rb_entry()

From	Juergen Gross <jgross@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xen/evtchn: use rb_entry()
Date	2016-12-22 10:10 +0100
Message-ID	<sR7xU-7u5-33@gated-at.bofh.it> (permalink)
References	<sQth7-6Ck-5@gated-at.bofh.it> <sQth8-6Ck-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 20/12/16 15:02, Geliang Tang wrote:
> To make the code clearer, use rb_entry() instead of container_of() to
> deal with rbtree.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>

Committed to xen/tip.git for-linus-4.10


Juergen

> ---
>  drivers/xen/evtchn.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
> index e8c7f09..6890897 100644
> --- a/drivers/xen/evtchn.c
> +++ b/drivers/xen/evtchn.c
> @@ -125,7 +125,7 @@ static int add_evtchn(struct per_user_data *u, struct user_evtchn *evtchn)
>  	while (*new) {
>  		struct user_evtchn *this;
>  
> -		this = container_of(*new, struct user_evtchn, node);
> +		this = rb_entry(*new, struct user_evtchn, node);
>  
>  		parent = *new;
>  		if (this->port < evtchn->port)
> @@ -157,7 +157,7 @@ static struct user_evtchn *find_evtchn(struct per_user_data *u, unsigned port)
>  	while (node) {
>  		struct user_evtchn *evtchn;
>  
> -		evtchn = container_of(node, struct user_evtchn, node);
> +		evtchn = rb_entry(node, struct user_evtchn, node);
>  
>  		if (evtchn->port < port)
>  			node = node->rb_left;
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] xen/evtchn: use rb_entry() Geliang Tang <geliangtang@gmail.com> - 2016-12-20 15:10 +0100
  Re: [PATCH] xen/evtchn: use rb_entry() Juergen Gross <jgross@suse.com> - 2016-12-20 17:30 +0100
  Re: [PATCH] xen/evtchn: use rb_entry() Juergen Gross <jgross@suse.com> - 2016-12-22 10:10 +0100

csiph-web