Re: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks.

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks.
Date	2016-12-22 02:30 +0100
Message-ID	<sR0mK-2AR-25@gated-at.bofh.it> (permalink)
References	<sOnIR-2Wp-3@gated-at.bofh.it> <sOnSx-35n-5@gated-at.bofh.it> <sQYkV-1n1-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Stephen Boyd <sboyd@codeaurora.org> writes:

> On 12/14, Eric Anholt wrote:
>>  
>>  	/* the gates */
>>  
>> @@ -1890,8 +1976,18 @@ static int bcm2835_clk_probe(struct platform_device *pdev)
>>  	if (IS_ERR(cprman->regs))
>>  		return PTR_ERR(cprman->regs);
>>  
>> -	cprman->osc_name = of_clk_get_parent_name(dev->of_node, 0);
>> -	if (!cprman->osc_name)
>> +	for (i = 0; i < ARRAY_SIZE(cprman_parent_names); i++) {
>> +		cprman->real_parent_names[i] =
>> +			of_clk_get_parent_name(dev->of_node, i);
>> +	}
>
> Can we use of_clk_parent_fill() here? Or do we need to support
> holes in the parent array? If it's the latter please add a
> comment so we don't mistakenly change this later.

It looks like that will work fine.  We'll only be missing parents from
the end of the array.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/11] drm/vc4: DSI panel support + Raspberry Pi touchscreen Eric Anholt <eric@anholt.net> - 2016-12-14 20:50 +0100
  [PATCH 09/11] drm/panel: Add support for the Raspberry Pi 7" Touchscreen. Eric Anholt <eric@anholt.net> - 2016-12-14 20:50 +0100
  [PATCH 06/11] dt-bindings: Document the VC4 DSI module nodes. Eric Anholt <eric@anholt.net> - 2016-12-14 20:50 +0100
  [PATCH 08/11] dt-bindings: Document the Raspberry Pi Touchscreen nodes. Eric Anholt <eric@anholt.net> - 2016-12-14 20:50 +0100
  [PATCH 10/11] ARM: bcm2835: dt: Add the DSI module nodes and clocks. Eric Anholt <eric@anholt.net> - 2016-12-14 20:50 +0100
  [PATCH 05/11] drm/vc4: Add support for feeding DSI encoders from the pixel valve. Eric Anholt <eric@anholt.net> - 2016-12-14 20:50 +0100
  [PATCH 03/11] clk: bcm2835: Add leaf clock measurement support, disabled by default Eric Anholt <eric@anholt.net> - 2016-12-14 21:00 +0100
  [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks. Eric Anholt <eric@anholt.net> - 2016-12-14 21:00 +0100
    Re: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks. Stephen Boyd <sboyd@codeaurora.org> - 2016-12-22 00:20 +0100
      Re: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks. Eric Anholt <eric@anholt.net> - 2016-12-22 02:30 +0100

csiph-web