Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1545298

Re: [PATCH 6/6] KVM: lapic: do not scan IRR when delivering an interrupt

From Paolo Bonzini <pbonzini@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 6/6] KVM: lapic: do not scan IRR when delivering an interrupt
Date 2016-12-20 18:20 +0100
Message-ID <sQwf0-8sT-9@gated-at.bofh.it> (permalink)
References <sQ2JY-60r-5@gated-at.bofh.it> <sQ2JY-60r-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 19/12/2016 10:47, Paolo Bonzini wrote:
> +	if (!test_bit(vector, vcpu_to_synic(vcpu)->auto_eoi_bitmap))
> +		apic_set_isr(vector, apic);
>  
> +	apic_clear_irr(vector, apic);
> +	__apic_update_ppr(apic, &ppr);

Hmm, EOI does apic_update_ppr, so for auto-EOI interrupts I think it's
safer to do apic_update_ppr instead.  You could have to interrupts
injected at the same time, and the lower-priority interrupt would be
lost if the higher-priority interrupt does automatic EOI.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 6/6] KVM: lapic: do not scan IRR when delivering an interrupt Paolo Bonzini <pbonzini@redhat.com> - 2016-12-19 10:50 +0100
  Re: [PATCH 6/6] KVM: lapic: do not scan IRR when delivering an  interrupt Paolo Bonzini <pbonzini@redhat.com> - 2016-12-20 18:20 +0100

csiph-web