Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1545200
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359 |
| Date | 2016-12-20 16:30 +0100 |
| Message-ID | <sQuwy-7jd-23@gated-at.bofh.it> (permalink) |
| References | <sQivo-7Nz-1@gated-at.bofh.it> <sQqMh-4Vr-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/20/2016 05:21 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
>
>> With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of
>> kfree_skb"), the method used to free an skb was changed because the
>> kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb()
>> guards against a NULL value for the argument. Routine dev_kfree_skb_irq()
>> does not, and a test is needed to prevent kernel panics.
>>
>> Fixes: commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb")
>
> This should be:
>
> Fixes: e49656147359 ("rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb")
>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: Stable <stable@vger.kernel.org> (4.9+)
>
> And this:
>
> Cc: Stable <stable@vger.kernel.org> # 4.9+
>
> I can fix both of them.
>
>> Cc: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> Kalle,
>>
>> This change should be sent to mainline during the 4.10 merge period,
>> or as soon as possible.
>
> Ok, I'll queue this to 4.10. Most likely I'll send a pull request to
> Dave later this week or so.
Thanks for the suggested changes, and for the quick action.
Larry
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359 Larry Finger <Larry.Finger@lwfinger.net> - 2016-12-20 03:40 +0100
Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359 Kalle Valo <kvalo@codeaurora.org> - 2016-12-20 12:30 +0100
Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359 Larry Finger <Larry.Finger@lwfinger.net> - 2016-12-20 16:30 +0100
Re: rtlwifi: Fix kernel oops introduced with commit e49656147359 Kalle Valo <kvalo@codeaurora.org> - 2016-12-21 15:40 +0100
csiph-web