Re: [PATCH] scripts: checkincludes: add exit message for no duplicates found

From	Cheah Kok Cheong <thrust73@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scripts: checkincludes: add exit message for no duplicates found
Date	2016-12-20 10:20 +0100
Message-ID	<sQoKu-3Gs-17@gated-at.bofh.it> (permalink)
References	<sPIUW-7Lp-9@gated-at.bofh.it> <sQ3G2-6zz-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 19, 2016 at 11:47:47AM +0100, Michal Marek wrote:
> On 2016-12-18 13:35, Cheah Kok Cheong wrote:
> > If no duplicates found, inform user.
> > 
> > Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
> > ---
> >  scripts/checkincludes.pl | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl
> > index 97b2c61..2bf234c 100755
> > --- a/scripts/checkincludes.pl
> > +++ b/scripts/checkincludes.pl
> > @@ -37,6 +37,13 @@ if ($#ARGV >= 1) {
> >  	}
> >  }
> >  
> > +my $dup_counter = 0;
> > +
> > +sub nodup_count {
> > +	++$dup_counter;
> > +	return;
> > +}
> 
> I don't think it's necessary to have a function only to increment a
> variable.
> 
> Michal

Sorry do you mean the subroutine is not required and the "variable" is
best placed inside directly?

Thanks.
CheahKC

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scripts: checkincludes: add exit message for no duplicates found Cheah Kok Cheong <thrust73@gmail.com> - 2016-12-18 13:40 +0100
  Re: [PATCH] scripts: checkincludes: add exit message for no  duplicates found Michal Marek <mmarek@suse.com> - 2016-12-19 11:50 +0100
    Re: [PATCH] scripts: checkincludes: add exit message for no  duplicates found Cheah Kok Cheong <thrust73@gmail.com> - 2016-12-20 10:20 +0100

csiph-web