Re: [RFC] Question about freeing of resource in 'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'

Path	csiph.com!goblin1!goblin.stu.neva.ru!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Newsgroups	linux.kernel
Subject	Re: [RFC] Question about freeing of resource in 'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'
Date	Tue, 20 Dec 2016 06:50:01 +0100
Message-ID	<sQltf-1oo-5@gated-at.bofh.it> (permalink)
References	<sPZCp-49P-3@gated-at.bofh.it> <sQ6DU-8us-35@gated-at.bofh.it>
X-Original-To	Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>, linus.walleij@linaro.org, baohua@kernel.org
X-Me-Helo	[127.0.0.1]
X-Me-Date	Tue, 20 Dec 2016 06:44:10 +0100
X-Me-IP	92.140.161.60
User-Agent	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	8bit
X-Antivirus	avast! (VPS 161219-1, 19/12/2016), Outbound message
X-Antivirus-Status	Clean
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	14
Organization	linux.* mail to news gateway
X-Original-Cc	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
X-Original-Date	Tue, 20 Dec 2016 06:44:04 +0100
X-Original-Message-ID	<24932cf3-0fe2-c71f-231c-c2f05c96a3c9@wanadoo.fr>
X-Original-Newsgroups	gmane.linux.kernel.gpio,gmane.linux.ports.arm.kernel,gmane.linux.kernel,gmane.linux.kernel.janitors
X-Original-References	<612eedc5-0f28-7a38-abad-4b9573208875@wanadoo.fr> <7123e174-cc22-4a76-337c-661ee87994df@mentor.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1544907

Show key headers only | View raw

Le 19/12/2016 à 14:54, Vladimir Zapolskiy a écrit :
> Functionally it looks good, I have two comments though.
> 1) you don't need to revert 151b8c5ba1eb, the commit is a proper fix
>     per se but incomplete, please add your change on top of it,
>
> 2) minimizing the lines of code by removing duplicates is always good,
>     so here a better and complete fix will be like the following one:
>
Hi,

thanks for the feedback and comments.
Patch submitted.

CJ

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC] Question about freeing of resource in 'atlas7_pinmux_probe()',  in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c' Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-12-19 07:30 +0100
  Re: [RFC] Question about freeing of resource in  'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c' Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-12-19 15:00 +0100
    Re: [RFC] Question about freeing of resource in  'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-12-20 06:50 +0100

csiph-web