RE: [PATCH] block: loose check on sg gap

From	Dexuan Cui <decui@microsoft.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] block: loose check on sg gap
Date	2016-12-20 05:00 +0100
Message-ID	<sQjKN-99-5@gated-at.bofh.it> (permalink)
References	<sPkIV-8u9-17@gated-at.bofh.it> <sQi2l-7E6-7@gated-at.bofh.it> <sQi2l-7E6-5@gated-at.bofh.it> <sQjKN-99-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> From: Jens Axboe [mailto:axboe@fb.com]
> Sent: Tuesday, December 20, 2016 10:31
> To: Ming Lei <ming.lei@canonical.com>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; linux-block <linux-
> block@vger.kernel.org>; Christoph Hellwig <hch@infradead.org>; Dexuan Cui
> <decui@microsoft.com>; Vitaly Kuznetsov <vkuznets@redhat.com>; Keith Busch
> <keith.busch@intel.com>; Hannes Reinecke <hare@suse.de>; Mike Christie
> <mchristi@redhat.com>; Martin K. Petersen <martin.petersen@oracle.com>;
> Toshi Kani <toshi.kani@hpe.com>; Dan Williams <dan.j.williams@intel.com>;
> Damien Le Moal <damien.lemoal@hgst.com>
> Subject: Re: [PATCH] block: loose check on sg gap
> 
> On 12/19/2016 07:07 PM, Ming Lei wrote:
> > On Sun, Dec 18, 2016 at 12:49 AM, Jens Axboe <axboe@fb.com> wrote:
> >> On 12/17/2016 03:49 AM, Ming Lei wrote:
> >>> If the last bvec of the 1st bio and the 1st bvec of the next
> >>> bio are contineous physically, and the latter can be merged
> >>> to last segment of the 1st bio, we should think they don't
> >>> violate sg gap(or virt boundary) limit.
> >>>
> >>> Both Vitaly and Dexuan reported lots of unmergeable small bios
> >>> are observed when running mkfs on Hyper-V virtual storage, and
> >>> performance becomes quite low, so this patch is figured out for
> >>> fixing the performance issue.
> >>>
> >>> The same issue should exist on NVMe too sine it sets virt boundary too.
> >>
> >> It looks pretty reasonable to me. I'll queue it up for some testing,
> >> changes like this always make me a little nervous.
> >
> > Understood.
> >
> > But given it is still in early stage of 4.10 cycle, seems fine to expose
> > it now, and we should have enough time to fix it if there might be
> > regressions.
> >
> > BTW, it passes my xfstest(ext4) over sata/NVMe.
> 
> It's been fine here in testing, too. I'm not worried about performance
> regressions, those we can always fix. Merging makes me worried about
> corruption, and those regressions are much worse.
> 
> Any reason we need to rush this? I'd be more comfortable pushing this to
> 4.11, unless there are strong reasons this should make 4.10.
> 
> --
> Jens Axboe

Hi Jens,

As far as I know, the patch is important to popular Linux distros,
e.g. at least Ubuntu 14.04.5, 16.x and RHEL 7.3, when they run on 
Hyper-V/Azure, because they can suffer from a pretty bad throughput/latency
in some cases, e.g. mkfs.ext4 for a 100GB partition can take 8 minutes, but
with the patch, it only takes 1 second.

Thanks,
-- Dexuan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] block: loose check on sg gap Ming Lei <ming.lei@canonical.com> - 2016-12-17 11:50 +0100
  Re: [PATCH] block: loose check on sg gap Ming Lei <ming.lei@canonical.com> - 2016-12-20 03:10 +0100
    RE: [PATCH] block: loose check on sg gap Dexuan Cui <decui@microsoft.com> - 2016-12-20 05:00 +0100

csiph-web