[PATCH] mtd/redboot: avoid null pointer deref

From	"Jason A. Donenfeld" <Jason@zx2c4.com>
Newsgroups	linux.kernel
Subject	[PATCH] mtd/redboot: avoid null pointer deref
Date	2016-12-22 00:30 +0100
Message-ID	<sQYuB-1qn-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

By giving a bogus partition name, it's possible to trigger a null
pointer dereference.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 drivers/mtd/redboot.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/redboot.c b/drivers/mtd/redboot.c
index 7623ac5fc586..53949ef80d36 100644
--- a/drivers/mtd/redboot.c
+++ b/drivers/mtd/redboot.c
@@ -212,6 +212,10 @@ static int parse_redboot_partitions(struct mtd_info *master,
 
 		nrparts++;
 	}
+	if (!fl) {
+		ret = -EINVAL;
+		goto out;
+	}
 #ifdef CONFIG_MTD_REDBOOT_PARTS_UNALLOCATED
 	if (fl->img->flash_base) {
 		nrparts++;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd/redboot: avoid null pointer deref "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-22 00:30 +0100
  Re: [PATCH] mtd/redboot: avoid null pointer deref Marek Vasut <marek.vasut@gmail.com> - 2017-01-03 03:30 +0100

csiph-web