Re: jemalloc testsuite stalls in memset

From	Minchan Kim <minchan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: jemalloc testsuite stalls in memset
Date	2016-12-22 01:00 +0100
Message-ID	<sQYXD-1An-3@gated-at.bofh.it> (permalink)
References	<sOiSR-7Aq-11@gated-at.bofh.it> <sOrCO-6Q9-41@gated-at.bofh.it> <sOAwp-42f-3@gated-at.bofh.it> <sOUlr-8gn-1@gated-at.bofh.it> <sP1wC-4Nh-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello, Andreas

Sorry for long delay. I was on vacation.

On Fri, Dec 16, 2016 at 03:16:20PM +0100, Andreas Schwab wrote:
> On Dez 16 2016, Minchan Kim <minchan@kernel.org> wrote:
> 
> > Below helps?
> >
> > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> > index e10a4fe..dc37c9a 100644
> > --- a/mm/huge_memory.c
> > +++ b/mm/huge_memory.c
> > @@ -1611,6 +1611,7 @@ int madvise_free_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma,
> >  			tlb->fullmm);
> >  		orig_pmd = pmd_mkold(orig_pmd);
> >  		orig_pmd = pmd_mkclean(orig_pmd);
> > +		orig_pmd = pmd_wrprotect(orig_pmd);
> >  
> >  		set_pmd_at(mm, addr, pmd, orig_pmd);
> >  		tlb_remove_pmd_tlb_entry(tlb, pmd, addr);
> 
> Thanks, this fixes the issue (tested with 4.9).

It was a quick hack to know what exact problem is there and your confirming
helped a lot to understand the problem clear.

More right approach is to support pmd dirty handling in general page fault
handler rather than tweaking MADV_FREE. I just sent a new patch with Ccing
you.

Could you test it, please?
Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

jemalloc testsuite stalls in memset Andreas Schwab <schwab@suse.de> - 2016-12-14 15:40 +0100
  Re: jemalloc testsuite stalls in memset Minchan Kim <minchan@kernel.org> - 2016-12-15 01:00 +0100
    Re: jemalloc testsuite stalls in memset Andreas Schwab <schwab@suse.de> - 2016-12-15 10:30 +0100
      Re: jemalloc testsuite stalls in memset Minchan Kim <minchan@kernel.org> - 2016-12-16 07:40 +0100
        Re: jemalloc testsuite stalls in memset Andreas Schwab <schwab@suse.de> - 2016-12-16 15:20 +0100
          Re: jemalloc testsuite stalls in memset Minchan Kim <minchan@kernel.org> - 2016-12-22 01:00 +0100

csiph-web