Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1546000

Patch to include/linux/kernel.h breaks 3rd party modules.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Yes, I know that usually out-of-tree modules are on their own.
However, this one may require a rethink..

(Sorry for not catching this sooner, I hadn't tried to deal with the
affected module since this patch hit linux-next in next-20161128)

commit 7fd8329ba502ef76dd91db561c7aed696b2c7720
Author: Petr Mladek <pmladek@suse.com>
Date:   Wed Sep 21 13:47:22 2016 +0200

    taint/module: Clean up global and module taint flags handling

Contains this chunk:

--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -506,6 +506,15 @@ extern enum system_states {
 #define TAINT_UNSIGNED_MODULE          13
 #define TAINT_SOFTLOCKUP               14
 #define TAINT_LIVEPATCH                        15
+#define TAINT_FLAGS_COUNT              16
+
+struct taint_flag {
+       char true;      /* character printed when tainted */
+       char false;     /* character printed when not tainted */
+       bool module;    /* also show as a per-module taint flag */
+};

and hilarity ensues when an out-of-tree module has this:

# ifndef true
#  define true  (1)
# endif
# ifndef false
#  define false (0)
# endif

My proposed fix: change true/false to tainted/untainted.  If this
is agreeable, I'll code and submit the fix.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Patch to include/linux/kernel.h breaks 3rd party modules. Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2016-12-21 21:50 +0100
  Re: Patch to include/linux/kernel.h breaks 3rd party modules. Jessica Yu <jeyu@redhat.com> - 2016-12-21 22:30 +0100
  Re: Patch to include/linux/kernel.h breaks 3rd party modules. Al Viro <viro@ZenIV.linux.org.uk> - 2016-12-22 02:00 +0100
  Re: Patch to include/linux/kernel.h breaks 3rd party modules. Christoph Hellwig <hch@infradead.org> - 2016-12-22 07:30 +0100
  Re: Patch to include/linux/kernel.h breaks 3rd party modules. Petr Mladek <pmladek@suse.com> - 2016-12-22 11:50 +0100

csiph-web