Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1545855
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH perf/core REBASE 3/5] tools lib bpf: Add bpf_prog_{attach,detach} |
| Date | 2016-12-21 17:10 +0100 |
| Message-ID | <sQRCO-5Db-25@gated-at.bofh.it> (permalink) |
| References | <sOqGK-6gP-9@gated-at.bofh.it> <sOqQp-6zC-7@gated-at.bofh.it> <sQtqN-6G9-3@gated-at.bofh.it> <sQtKa-6MJ-13@gated-at.bofh.it> <sQxNL-Pw-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Em Tue, Dec 20, 2016 at 10:50:22AM -0800, Joe Stringer escreveu:
> On 20 December 2016 at 06:32, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Em Tue, Dec 20, 2016 at 11:18:51AM -0300, Arnaldo Carvalho de Melo escreveu:
> >> This one makes it fail for CentOS 5 and 6, others may fail as well,
> >> still building, investigating...
> >
> > Ok, fixed it by making it follow the model of the other sys_bpf wrappers
> > setting up that bpf_attr union wrt initializing unamed struct members:
> > - union bpf_attr attr = {
> > - .target_fd = target_fd,
> > - };
> > + union bpf_attr attr;
> > +
> > + bzero(&attr, sizeof(attr));
> > + attr.target_fd = target_fd;
> Ah, I just shifted these across originally so the delta would be
> minimal but now I know why this code is like this. Thanks.
np, making sure this code works in all those environments requires
automation, I'd say its impossible otherwise, too many details :-\
Fixed, pushed, merged, should hit 4.10 soon :-)
- Arnaldo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH perf/core REBASE 0/5] Reuse libbpf from samples/bpf Joe Stringer <joe@ovn.org> - 2016-12-15 00:00 +0100
[PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Joe Stringer <joe@ovn.org> - 2016-12-15 00:00 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-15 17:00 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-15 19:40 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-15 19:50 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-15 19:50 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Joe Stringer <joe@ovn.org> - 2016-12-15 23:10 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Joe Stringer <joe@ovn.org> - 2016-12-16 02:50 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-12-16 15:30 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-16 16:50 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-20 14:50 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Joe Stringer <joe@ovn.org> - 2016-12-15 19:40 +0100
Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-15 20:10 +0100
[PATCH perf/core REBASE 3/5] tools lib bpf: Add bpf_prog_{attach,detach} Joe Stringer <joe@ovn.org> - 2016-12-15 00:10 +0100
Re: [PATCH perf/core REBASE 3/5] tools lib bpf: Add bpf_prog_{attach,detach} Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-20 15:20 +0100
Re: [PATCH perf/core REBASE 3/5] tools lib bpf: Add bpf_prog_{attach,detach} Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-20 15:40 +0100
Re: [PATCH perf/core REBASE 3/5] tools lib bpf: Add bpf_prog_{attach,detach} Joe Stringer <joe@ovn.org> - 2016-12-20 20:00 +0100
Re: [PATCH perf/core REBASE 3/5] tools lib bpf: Add bpf_prog_{attach,detach} Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-21 17:10 +0100
[PATCH perf/core REBASE 4/5] samples/bpf: Remove perf_event_open() declaration Joe Stringer <joe@ovn.org> - 2016-12-15 00:10 +0100
[PATCH perf/core REBASE 1/5] samples/bpf: Make samples more libbpf-centric Joe Stringer <joe@ovn.org> - 2016-12-15 00:10 +0100
[tip:perf/urgent] samples/bpf: Make samples more libbpf-centric tip-bot for Joe Stringer <tipbot@zytor.com> - 2016-12-20 20:30 +0100
[PATCH perf/core REBASE 5/5] samples/bpf: Move open_raw_sock to separate header Joe Stringer <joe@ovn.org> - 2016-12-15 00:10 +0100
csiph-web