Re: [PATCH] net: macb: Applied changes according to review made by Andy Shevchenko.

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: macb: Applied changes according to review made by Andy Shevchenko.
Date	2016-12-21 17:10 +0100
Message-ID	<sQRCN-5Db-9@gated-at.bofh.it> (permalink)
References	<sQMD7-2fN-27@gated-at.bofh.it> <sQMD7-2fN-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Bartosz Folta <bfolta@cadence.com>
Date: Wed, 21 Dec 2016 08:53:05 +0000

> This patch is sent in regard to recently applied patch
> Commit 83a77e9ec4150ee4acc635638f7dedd9da523a26
> net: macb: Added PCI wrapper for Platform Driver.
> Andy's review does not appear on mailing lists. I can't reference it.
> 
> Signed-off-by: Bartosz Folta <bfolta@cadence.com>

This commit log message and Subject line need a lot of improvement.

You should be saying what exactly you are doing, rather than "someone
said I should do this".  The latter gives the reader no information
whatsoever about what the patch is doing.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: macb: Applied changes according to review made by Andy  Shevchenko. Bartosz Folta <bfolta@cadence.com> - 2016-12-21 11:50 +0100
  Re: [PATCH] net: macb: Applied changes according to review made by  Andy Shevchenko. David Miller <davem@davemloft.net> - 2016-12-21 17:10 +0100

csiph-web