[PATCH] input: synaptics-rmi4: remove redundant null check on rmi_dev

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] input: synaptics-rmi4: remove redundant null check on rmi_dev
Date	2016-12-21 15:50 +0100
Message-ID	<sQQno-4FS-21@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

rmi_dev is currently being dereferenced before it null checked,
however, after deeper inspecting, rmi_dev can never be null,
so just remove this redundant check. Thanks to Dmitry Torokhov for
noticing that we can remove the null check.

Fixes CoverityScan CID 1391218 ("Dereference before null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/input/rmi4/rmi_f03.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/input/rmi4/rmi_f03.c b/drivers/input/rmi4/rmi_f03.c
index 8a7ca3e..9a1b099 100644
--- a/drivers/input/rmi4/rmi_f03.c
+++ b/drivers/input/rmi4/rmi_f03.c
@@ -175,9 +175,6 @@ static int rmi_f03_attention(struct rmi_function *fn, unsigned long *irq_bits)
 	int i;
 	int error;
 
-	if (!rmi_dev)
-		return -ENODEV;
-
 	if (drvdata->attn_data.data) {
 		/* First grab the data passed by the transport device */
 		if (drvdata->attn_data.size < ob_len) {
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] input: synaptics-rmi4: remove redundant null check on rmi_dev Colin King <colin.king@canonical.com> - 2016-12-21 15:50 +0100
  Re: [PATCH] input: synaptics-rmi4: remove redundant null check on  rmi_dev Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-29 19:30 +0100

csiph-web