Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1545802

[PATCHv6 1/7] printk: use vprintk_func in vprintk()

Show all headers | View raw

vprintk(), just like printk(), better be using per-cpu printk_func
instead of direct vprintk_emit() call. Just in case if vprintk()
will ever be called from NMI, or from any other context that can
deadlock in printk().

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
---
 kernel/printk/printk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index e2cdd87e7a63..265e815730f9 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1803,7 +1803,7 @@ EXPORT_SYMBOL(vprintk_emit);
 
 asmlinkage int vprintk(const char *fmt, va_list args)
 {
-	return vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, 0, fmt, args);
+	return vprintk_func(fmt, args);
 }
 EXPORT_SYMBOL(vprintk);
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv6 0/7] printk: use printk_safe to handle printk() recursive calls Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-12-21 15:40 +0100
  [PATCHv6 6/7] printk: use printk_safe buffers in printk Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-12-21 15:40 +0100
    Re: [PATCHv6 6/7] printk: use printk_safe buffers in printk Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-22 06:40 +0100
      Re: [PATCHv6 6/7] printk: use printk_safe buffers in printk Petr Mladek <pmladek@suse.com> - 2016-12-22 18:20 +0100
        Re: [PATCHv6 6/7] printk: use printk_safe buffers in printk Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-23 02:50 +0100
          Re: [PATCHv6 6/7] printk: use printk_safe buffers in printk Petr Mladek <pmladek@suse.com> - 2016-12-23 11:00 +0100
  [PATCHv6 7/7] printk: remove zap_locks() function Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-12-21 15:40 +0100
  [PATCHv6 2/7] printk: rename nmi.c and exported api Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-12-21 15:40 +0100
    Re: [PATCHv6 2/7] printk: rename nmi.c and exported api Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-21 20:50 +0100
      Re: [PATCHv6 2/7] printk: rename nmi.c and exported api Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-22 02:20 +0100
  [PATCHv6 1/7] printk: use vprintk_func in vprintk() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-12-21 15:40 +0100
  [PATCHv6 4/7] printk: always use deferred printk when flush printk_safe lines Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-12-21 15:50 +0100
  [PATCHv6 3/7] printk: introduce per-cpu safe_print seq buffer Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-12-21 15:50 +0100
    Re: [PATCHv6 3/7] printk: introduce per-cpu safe_print seq buffer Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-22 02:20 +0100
      Re: [PATCHv6 3/7] printk: introduce per-cpu safe_print seq buffer Petr Mladek <pmladek@suse.com> - 2016-12-22 17:40 +0100

csiph-web