Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1545739

Re: at86rf230: Allow slow GPIO pins for "rstn"

From Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Newsgroups linux.kernel
Subject Re: at86rf230: Allow slow GPIO pins for "rstn"
Date 2016-12-21 13:40 +0100
Message-ID <sQOlA-3sa-13@gated-at.bofh.it> (permalink)
References <sPT3X-8nv-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> Driver code never touches "rstn" signal in atomic context, so there's
> no need to implicitly put such restriction on it by using gpio_set_value
> to manipulate it. Replace gpio_set_value to gpio_set_value_cansleep to
> fix that.
> 
> As a an example of where such restriction might be inconvenient,
> consider a hardware design where "rstn" is connected to a pin of I2C/SPI
> GPIO expander chip.
> 
> Cc: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>

Reviewed-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] at86rf230: Allow slow GPIO pins for "rstn" Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-12-19 00:30 +0100
  Re: at86rf230: Allow slow GPIO pins for "rstn" Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2016-12-21 13:40 +0100
  Re: [PATCH] at86rf230: Allow slow GPIO pins for "rstn" Stefan Schmidt <stefan@osg.samsung.com> - 2016-12-21 14:20 +0100
    Re: [PATCH] at86rf230: Allow slow GPIO pins for "rstn" Stefan Schmidt <stefan@osg.samsung.com> - 2016-12-21 22:10 +0100

csiph-web