Re: [RFC][PATCH] make global bitlock waitqueues per-node

From	Nicholas Piggin <npiggin@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH] make global bitlock waitqueues per-node
Date	2016-12-21 11:30 +0100
Message-ID	<sQMjL-286-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <sQgtz-6D2-9@gated-at.bofh.it> <sQgtz-6D2-7@gated-at.bofh.it> <sQwym-89-9@gated-at.bofh.it> <sQx1o-ys-31@gated-at.bofh.it> <sQK8h-Qv-1@gated-at.bofh.it>
Organization	IBM

Show all headers | View raw

On Wed, 21 Dec 2016 09:09:31 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, Dec 20, 2016 at 10:02:46AM -0800, Linus Torvalds wrote:
> > On Tue, Dec 20, 2016 at 9:31 AM, Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:  
> > >
> > > I'll go back and try to see why the page flag contention patch didn't
> > > get applied.  
> > 
> > Ahh, a combination of warring patches by Nick and PeterZ, and worry
> > about the page flag bits.  
> 
> I think Nick actually had a patch freeing up a pageflag, although Hugh
> had a comment on that.

Yeah I think he basically acked it. It had a small compound debug
false positive but I think it's okay. I'm just testing it again.

> That said, I'm not a huge fan of his waiters patch, I'm still not sure
> why he wants to write another whole wait loop, but whatever. Whichever
> you prefer I suppose.

Ah, I was waiting for some feedback, thanks.

Well I wanted to do it that way to keep the manipulation of the new
bit under the same lock as the waitqueue, so as not to introduce new
memory orderings vs testing waitqueue_active.

Thanks,
Nick

Thread

[RFC][PATCH] make global bitlock waitqueues per-node Dave Hansen <dave.hansen@linux.intel.com> - 2016-12-20 00:00 +0100
  Re: [RFC][PATCH] make global bitlock waitqueues per-node Dave Hansen <dave.hansen@linux.intel.com> - 2016-12-20 01:30 +0100
    Re: [RFC][PATCH] make global bitlock waitqueues per-node Nicholas Piggin <npiggin@gmail.com> - 2016-12-20 03:40 +0100
      Re: [RFC][PATCH] make global bitlock waitqueues per-node Mel Gorman <mgorman@techsingularity.net> - 2016-12-20 14:00 +0100
        Re: [RFC][PATCH] make global bitlock waitqueues per-node Nicholas Piggin <npiggin@gmail.com> - 2016-12-20 14:30 +0100
    Re: [RFC][PATCH] make global bitlock waitqueues per-node Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-20 18:40 +0100
      Re: [RFC][PATCH] make global bitlock waitqueues per-node Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-20 19:10 +0100
        Re: [RFC][PATCH] make global bitlock waitqueues per-node Peter Zijlstra <peterz@infradead.org> - 2016-12-21 09:10 +0100
          Re: [RFC][PATCH] make global bitlock waitqueues per-node Peter Zijlstra <peterz@infradead.org> - 2016-12-21 09:40 +0100
            Re: [RFC][PATCH] make global bitlock waitqueues per-node Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-21 19:10 +0100
              Re: [RFC][PATCH] make global bitlock waitqueues per-node Nicholas Piggin <npiggin@gmail.com> - 2016-12-21 19:40 +0100
                Re: [RFC][PATCH] make global bitlock waitqueues per-node Nicholas Piggin <npiggin@gmail.com> - 2016-12-21 20:10 +0100
                Re: [RFC][PATCH] make global bitlock waitqueues per-node Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-21 21:00 +0100
                Re: [RFC][PATCH] make global bitlock waitqueues per-node Nicholas Piggin <npiggin@gmail.com> - 2016-12-22 03:10 +0100
              Re: [RFC][PATCH] make global bitlock waitqueues per-node Hugh Dickins <hughd@google.com> - 2016-12-22 20:30 +0100
          Re: [RFC][PATCH] make global bitlock waitqueues per-node Nicholas Piggin <npiggin@gmail.com> - 2016-12-21 11:30 +0100
  Re: [RFC][PATCH] make global bitlock waitqueues per-node Nicholas Piggin <npiggin@gmail.com> - 2016-12-20 03:30 +0100
  Re: [RFC][PATCH] make global bitlock waitqueues per-node Nicholas Piggin <npiggin@gmail.com> - 2016-12-21 13:40 +0100
    Re: [RFC][PATCH] make global bitlock waitqueues per-node Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-21 19:20 +0100
      Re: [RFC][PATCH] make global bitlock waitqueues per-node Nicholas Piggin <npiggin@gmail.com> - 2016-12-21 19:50 +0100

csiph-web