Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1545688

Re: [PATCHSET] kernfs, cgroup: reimplement "cgroup.procs" reading for v2

Show all headers | View raw

On Tue, Dec 20, 2016 at 11:12:17AM -0500, Tejun Heo wrote:
> On cgroup v1, the pid listings in "cgroup.procs" and "tasks" are
> sorted which adds a lot of complications and overhead.  v2 doesn't
> have such requirement and has been intentionally using a modified
> sorting order so that the output doesn't look sorted to users.
> 
> This patchset re-implements "cgroup.procs" reading for v2 which simply
> keeps a css_task_iter open while the file is being read.  Keeping the
> iterator open makes it unnecessary to skip to the right position on
> each read segment and associated errors - e.g. incorrectly skipping
> over pids because earlier pids disappeared between the reads.
> 
> Using persistent iterator across multiple read calls requires
> ->release() callback to clean it up.  kernfs operations
> ->open/release() are added and piped through cftype.
> 
> This patchset contains the following five patches.
> 
>  0001-kernfs-make-kernfs_open_file-mmapped-a-bitfield.patch
>  0002-kernfs-add-kernfs_ops-open-release-callbacks.patch
>  0003-cgroup-add-cftype-open-release-callbacks.patch
>  0004-cgroup-reimplement-reading-cgroup.procs-on-cgroup-v2.patch
>  0005-cgroup-remove-cgroup_pid_fry-and-friends.patch
> 
> 0001 is a misc kernfs patch and 0002 adds ->open/release() to kernfs.
> 0003 pipes ->open/release() through cftype.  0004 implements the new
> cgroup.procs for v2 and 0005 removes the now unused sort order frying
> logic.
> 
> Greg, would it be okay to route the kernfs patches through
> cgroup/for-4.11?

No objection from me at all:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET] kernfs, cgroup: reimplement "cgroup.procs" reading for v2 Tejun Heo <tj@kernel.org> - 2016-12-20 17:20 +0100
  Re: [PATCHSET] kernfs, cgroup: reimplement "cgroup.procs" reading  for v2 Greg KH <gregkh@linuxfoundation.org> - 2016-12-21 11:00 +0100
  Re: [PATCHSET] kernfs, cgroup: reimplement "cgroup.procs" reading for  v2 Zefan Li <lizefan@huawei.com> - 2016-12-26 07:30 +0100
  Re: [PATCHSET] kernfs, cgroup: reimplement "cgroup.procs" reading  for v2 Tejun Heo <tj@kernel.org> - 2016-12-27 21:10 +0100

csiph-web