Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1545646
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set |
| Date | 2016-12-21 09:00 +0100 |
| Message-ID | <sQJYB-xo-9@gated-at.bofh.it> (permalink) |
| References | <sQIpP-8aA-1@gated-at.bofh.it> <sQJvA-nE-25@gated-at.bofh.it> <sQIpP-8aA-3@gated-at.bofh.it> <sQJvA-nE-23@gated-at.bofh.it> <sQJYB-xo-1@gated-at.bofh.it> |
| Organization | Samsung Electronics |
Hi,
On 2016년 12월 21일 16:55, Baolin Wang wrote:
> Hi,
>
> On 21 December 2016 at 15:22, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> Hi,
>>
>> On 2016년 12월 21일 15:10, Baolin Wang wrote:
>>> According to the documentation, we should set the EXTCON_USB when
>>> one SDP charger connector was reported.
>>>
>>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>>> ---
>>> drivers/extcon/extcon-axp288.c | 7 ++++++-
>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
>>> index 42f41e8..4490726 100644
>>> --- a/drivers/extcon/extcon-axp288.c
>>> +++ b/drivers/extcon/extcon-axp288.c
>>> @@ -102,6 +102,7 @@ enum axp288_extcon_irq {
>>> };
>>>
>>> static const unsigned int axp288_extcon_cables[] = {
>>> + EXTCON_USB,
>>> EXTCON_CHG_USB_SDP,
>>> EXTCON_CHG_USB_CDP,
>>> EXTCON_CHG_USB_DCP,
>>> @@ -225,8 +226,12 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info)
>>> vbus_attach ? USB_EVENT_VBUS : USB_EVENT_NONE, NULL);
>>> }
>>>
>>> - if (notify_charger)
>>> + if (notify_charger) {
>>> extcon_set_state_sync(info->edev, cable, vbus_attach);
>>> + if (cable == EXTCON_CHG_USB_SDP)
>>> + extcon_set_state_sync(info->edev, EXTCON_USB,
>>> + vbus_attach);
>>> + }
>>>
>>> /* Clear the flags on disconnect event */
>>> if (!vbus_attach)
>>>
>>
>> The extcon-axp288.c driver has some patches on extcon-next[1] branch.
>> [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next
>>
>> I rework your patch on extcon-next branch as following:
>> If you ok, I'll merge it for v4.11.
>
> It is okay for me. Thanks.
Applied it. Thanks.
[snip]
--
Regards,
Chanwoo Choi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_* Baolin Wang <baolin.wang@linaro.org> - 2016-12-21 07:20 +0100
[PATCH 2/3] extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Baolin Wang <baolin.wang@linaro.org> - 2016-12-21 07:20 +0100
Re: [PATCH 2/3] extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-21 08:30 +0100
Re: [PATCH 2/3] extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Baolin Wang <baolin.wang@linaro.org> - 2016-12-21 09:00 +0100
Re: [PATCH 2/3] extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-21 09:00 +0100
[PATCH 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Baolin Wang <baolin.wang@linaro.org> - 2016-12-21 07:20 +0100
Re: [PATCH 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-21 08:30 +0100
Re: [PATCH 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Baolin Wang <baolin.wang@linaro.org> - 2016-12-21 09:00 +0100
Re: [PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_* Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-21 08:30 +0100
Re: [PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_* Baolin Wang <baolin.wang@linaro.org> - 2016-12-21 09:00 +0100
Re: [PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_* Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-21 09:00 +0100
Re: [PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_* Baolin Wang <baolin.wang@linaro.org> - 2016-12-21 09:00 +0100
csiph-web