Re: [PATCH 1/1] xfs: silent -Wformat-security warning

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] xfs: silent -Wformat-security warning
Date	2016-12-19 17:10 +0100
Message-ID	<sQ8FH-1Hm-35@gated-at.bofh.it> (permalink)
References	<sQ6ud-8qH-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 19, 2016 at 02:41:11PM +0100, Nicolas Iooss wrote:
> When building the XFS driver with clang, the compiler reports a
> -Wformat-security warning in xlog_recover_validate_buf_type() because
> xfs_warn() is being called with a non-literal string. Even though
> variable warnmsg is always initialized as a constant string without any
> '%' character, silent the warning by calling xfs_warn with "%s" format
> string.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>

Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] xfs: silent -Wformat-security warning Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2016-12-19 14:50 +0100
  Re: [PATCH 1/1] xfs: silent -Wformat-security warning Christoph Hellwig <hch@infradead.org> - 2016-12-19 17:10 +0100

csiph-web