Re: [PATCH 1/2] nvme : Use correct scnprintf in cmb show

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Jon Derrick <jonathan.derrick@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] nvme : Use correct scnprintf in cmb show
Date	Mon, 19 Dec 2016 16:30:02 +0100
Message-ID	<sQ830-1eW-3@gated-at.bofh.it> (permalink)
References	<sP6mB-7Nv-9@gated-at.bofh.it> <sP6FY-7TO-3@gated-at.bofh.it>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.33,374,1477983600"; d="scan'208";a="204561297"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, axboe@fb.com, sagi@grimberg.me, james_p_freyensee@linux.intel.com
X-Original-Date	Mon, 19 Dec 2016 08:20:14 -0700
X-Original-Message-ID	<20161219152013.GA3512@localhost.localdomain>
X-Original-References	<1481914491-21456-1-git-send-email-sbates@raithlin.com> <1481914491-21456-2-git-send-email-sbates@raithlin.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1544616

Show key headers only | View raw

Looks good. Thanks Stephen.

Reviewed-by Jon Derrick: <jonathan.derrick@intel.com>

On Fri, Dec 16, 2016 at 11:54:50AM -0700, Stephen Bates wrote:
> Make sure we are using the correct scnprintf in the sysfs show
> function for the CMB.
> 
> Signed-off-by: Stephen Bates <sbates@raithlin.com>
> ---
>  drivers/nvme/host/pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 5e52034..be10860 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -50,7 +50,7 @@
>  #define NVME_AQ_DEPTH		256
>  #define SQ_SIZE(depth)		(depth * sizeof(struct nvme_command))
>  #define CQ_SIZE(depth)		(depth * sizeof(struct nvme_completion))
> -		
> +
>  /*
>   * We handle AEN commands ourselves and don't even let the
>   * block layer know about them.
> @@ -1332,7 +1332,7 @@ static ssize_t nvme_cmb_show(struct device *dev,
>  {
>  	struct nvme_dev *ndev = to_nvme_dev(dev_get_drvdata(dev));
>  
> -	return snprintf(buf, PAGE_SIZE, "cmbloc : x%08x\ncmbsz  : x%08x\n",
> +	return scnprintf(buf, PAGE_SIZE, "cmbloc : x%08x\ncmbsz  : x%08x\n",
>  		       ndev->cmbloc, ndev->cmbsz);
>  }
>  static DEVICE_ATTR(cmb, S_IRUGO, nvme_cmb_show, NULL);
> -- 
> 2.1.4
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] nvme : Use correct scnprintf in cmb show Stephen Bates <sbates@raithlin.com> - 2016-12-16 20:50 +0100
  Re: [PATCH 1/2] nvme : Use correct scnprintf in cmb show Jon Derrick <jonathan.derrick@intel.com> - 2016-12-19 16:30 +0100

csiph-web