Re: [PATCH v4 3/4] KVM: x86: make interrupt delivery fast and slow path behave the same

From	David Hildenbrand <david@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/4] KVM: x86: make interrupt delivery fast and slow path behave the same
Date	2016-12-19 16:00 +0100
Message-ID	<sQ7zY-ML-25@gated-at.bofh.it> (permalink)
References	<sOHHA-8tl-5@gated-at.bofh.it> <sOHHA-8tl-29@gated-at.bofh.it> <sP3RM-69y-19@gated-at.bofh.it> <sP41r-6cL-15@gated-at.bofh.it> <sP4b7-6vt-19@gated-at.bofh.it>
Organization	Red Hat GmbH

Show all headers | View raw

Am 16.12.2016 um 18:07 schrieb Radim Krčmář:
> 2016-12-16 17:53+0100, Paolo Bonzini:
>> On 16/12/2016 17:41, David Hildenbrand wrote:
>>>
>>> Just to verify:
>>>
>>> The GET_APIC_DEST_FIELD(mda) == APIC_BROADCAST is still correct in
>>> kvm_apic_broadcast() ?
>>
>> No, it seems wrong.
>
> Definitely, sending v4 of this patch.
> I'll also add broadcast address check into kvm-unit-tests ...
> ---8<---
> Slow path tried to prevent IPIs from x2APIC VCPUs from being delivered
> to xAPIC VCPUs and vice-versa.  Make slow path behave like fast path,
> which never distinguished that.
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
>  v4: fix xAPIC broadcast address detection [David]
> ---
>  arch/x86/kvm/lapic.c | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)
>

Looks good to me.

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 3/4] KVM: x86: make interrupt delivery fast and slow path behave the same Radim Krčmář <rkrcmar@redhat.com> - 2016-12-15 18:10 +0100
  Re: [PATCH v3 3/4] KVM: x86: make interrupt delivery fast and slow  path behave the same David Hildenbrand <david@redhat.com> - 2016-12-16 17:50 +0100
    Re: [PATCH v3 3/4] KVM: x86: make interrupt delivery fast and slow  path behave the same Paolo Bonzini <pbonzini@redhat.com> - 2016-12-16 18:00 +0100
      [PATCH v4 3/4] KVM: x86: make interrupt delivery fast and slow path  behave the same Radim Krčmář <rkrcmar@redhat.com> - 2016-12-16 18:10 +0100
        Re: [PATCH v4 3/4] KVM: x86: make interrupt delivery fast and slow  path behave the same David Hildenbrand <david@redhat.com> - 2016-12-19 16:00 +0100

csiph-web