Re: [GIT PULL] Quota, fsnotify, and ext2 changes for 4.10-rc1

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] Quota, fsnotify, and ext2 changes for 4.10-rc1
Date	Mon, 19 Dec 2016 14:20:02 +0100
Message-ID	<sQ61c-8fM-29@gated-at.bofh.it> (permalink)
References	<sQ2Ai-5X2-17@gated-at.bofh.it>
X-Original-To	Linus Torvalds <torvalds@linux-foundation.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	61
Organization	linux.* mail to news gateway
X-Original-Cc	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 19 Dec 2016 14:18:32 +0100
X-Original-Message-ID	<20161219131832.GA24199@quack2.suse.cz>
X-Original-References	<20161219093442.GD17598@quack2.suse.cz>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1544516

Show key headers only | View raw

Hello Linus,

On Mon 19-12-16 10:34:42, Jan Kara wrote:
>   could you please pull from
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_linus
> 
> to get changes to locking of some quota operations from dedicated quota mutex
> to s_umount semaphore, a fsnotify fix and a simple ext2 fix.
> 
> Top of the tree is 5716863e0f82. The full shortlog is:

Just after sending this pull request I've received a report from 0-day
testing that a warning in dquot_disable() hits on remount. It is just a
cosmetic thing but still I'd prefer to have this fixed and not have to deal
with reports of this warning. So I have pushed out one additional commit
to for_linus branch:

2700e6067c72 "quota: Fix bogus warning in dquot_disable()"

Sorry for the noise. I'm now going to dig into why my personal testing
didn't actually spot this earlier...

								Honza
> 
> Darrick J. Wong (1):
>       ext2: reject inodes with negative size
> 
> Jan Kara (8):
>       fs: Provide function to get superblock with exclusive s_umount
>       quota: Hold s_umount in exclusive mode when enabling / disabling quotas
>       quota: Use s_umount protection for quota operations
>       ocfs2: Protect periodic quota syncing with s_umount semaphore
>       quota: Remove dqonoff_mutex from dquot_scan_active()
>       ocfs2: Use s_umount for quota recovery protection
>       quota: Remove dqonoff_mutex
>       fsnotify: Fix possible use-after-free in inode iteration on umount
> 
> The diffstat is
> 
>  fs/ext2/inode.c         |   4 ++
>  fs/notify/inode_mark.c  |  45 ++++------------
>  fs/ocfs2/quota_global.c |  10 +++-
>  fs/ocfs2/quota_local.c  |  11 ++--
>  fs/ocfs2/super.c        |   1 -
>  fs/quota/dquot.c        | 134 +++++++++++++++++-------------------------------
>  fs/quota/quota.c        |  22 +++++---
>  fs/super.c              |  81 +++++++++++++++++++++--------
>  include/linux/fs.h      |   2 +
>  include/linux/quota.h   |   1 -
>  10 files changed, 151 insertions(+), 160 deletions(-)
> 
> 							Thanks
> 								Honza
> 
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[GIT PULL] Quota, fsnotify, and ext2 changes for 4.10-rc1 Jan Kara <jack@suse.cz> - 2016-12-19 10:40 +0100
  Re: [GIT PULL] Quota, fsnotify, and ext2 changes for 4.10-rc1 Jan Kara <jack@suse.cz> - 2016-12-19 14:20 +0100

csiph-web