Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1544430

Re: [PATCH] HID: asus: Fix keyboard support

Show all headers | View raw

On Sat, 10 Dec 2016, Benjamin Tissoires wrote:

> Sorry for breaking the existing device.
> 
> I have a few minor issues with your patch, but I'll let Jiri says
> whether or not you need a v2.
> 
> On Dec 10 2016 or thereabouts, Brendan McGrath wrote:
> > The previous submission which added Touchpad support broke the
> > Keyboard support of this driver. This patch:
> > 1. fixes the Keyboard support (by assigning drvdata->input);
> 
> This is actually what was breaking your keyboard (plus item 4 which is
> cosmetic). Ideally, this should be in a separate patch.
> 
> > 2. renames NOTEBOOK_QUIRKS to KEYBOARD_QUIRKS;
> > 3. adds the NO_INIT_REPORT quirk to the KEYBOARD_QUIRKS; and
> 
> Points 2 and 3 are actually improvements because I can't seem to find
> that previously the keyboard had this quirk. I understand it is
> valuable, but it should be in a different patch IMO.
> 
> > 4. sets the input->name to 'Asus Keyboard' for the keyboard 
> 
> Cosmetic, but so important :)
> 
> Anyway, the patch in its current form is:
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> 
> But it might be good to split it in 2 (it will depend on Jiri I guess).

Having it separate would be slightly better next time, but I don't 
consider that really to be a show stopper. Queuing in 
for-4.10/upstream-fixes, thanks.

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] HID: asus: Fix keyboard support Jiri Kosina <jikos@kernel.org> - 2016-12-19 11:30 +0100

csiph-web