Re: [PATCH 8/8] extcon: axp288: Fix the module not auto-loading

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 8/8] extcon: axp288: Fix the module not auto-loading
Date	2016-12-19 08:00 +0100
Message-ID	<sQ05r-4jb-1@gated-at.bofh.it> (permalink)
References	<sPTQl-tj-5@gated-at.bofh.it> <sQ05r-4jb-3@gated-at.bofh.it> <sPTQl-tj-21@gated-at.bofh.it>
Organization	Samsung Electronics

Show all headers | View raw

Hi Hans,

On 2016년 12월 19일 09:13, Hans de Goede wrote:
> Add a MODULE_DEVICE_TABLE to fix the module not auto-loading.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/extcon/extcon-axp288.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index a27ee68..509a5f9 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -320,8 +320,15 @@ static int axp288_extcon_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static const struct platform_device_id axp288_extcon_table[] = {
> +	{ .name = "axp288_extcon" },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(platform, axp288_extcon_table);
> +
>  static struct platform_driver axp288_extcon_driver = {
>  	.probe = axp288_extcon_probe,
> +	.id_table = axp288_extcon_table,
>  	.driver = {
>  		.name = "axp288_extcon",
>  	},
> 

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Regards,
Chanwoo Choi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 8/8] extcon: axp288: Fix the module not auto-loading Hans de Goede <hdegoede@redhat.com> - 2016-12-19 01:20 +0100
  Re: [PATCH 8/8] extcon: axp288: Fix the module not auto-loading Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-19 08:00 +0100

csiph-web