Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1544025

What is the function of arch/x86/purgatory/purgatory.c?

Show all headers | View raw

While checking the rtlwifi family of drivers using Sparse, I got the following 
warnings:

   CHECK   arch/x86/purgatory/purgatory.c
arch/x86/purgatory/purgatory.c:21:15: warning: symbol 'backup_dest' was not 
declared. Should it be static?
arch/x86/purgatory/purgatory.c:22:15: warning: symbol 'backup_src' was not 
declared. Should it be static?
arch/x86/purgatory/purgatory.c:23:15: warning: symbol 'backup_sz' was not 
declared. Should it be static?
arch/x86/purgatory/purgatory.c:25:4: warning: symbol 'sha256_digest' was not 
declared. Should it be static?
arch/x86/purgatory/purgatory.c:27:19: warning: symbol 'sha_regions' was not 
declared. Should it be static?
arch/x86/purgatory/purgatory.c:42:5: warning: symbol 'verify_sha256_digest' was 
not declared. Should it be static?
arch/x86/purgatory/purgatory.c:61:6: warning: symbol 'purgatory' was not 
declared. Should it be static?

Upon examination of the routine, I can see that if purgatory() should be static, 
then none of the code here will ever be accessed by any part of the kernel. Is 
there some bit of magic that is above my understanding, or is this a useless bit 
of code that has been forgotten and should be removed?

If the former, then I think there should be declarations so that the clueless 
like me are not confused.

Thanks,

Larry

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

What is the function of arch/x86/purgatory/purgatory.c? Larry Finger <Larry.Finger@lwfinger.net> - 2016-12-17 19:00 +0100
  Re: What is the function of arch/x86/purgatory/purgatory.c? Al Viro <viro@ZenIV.linux.org.uk> - 2016-12-17 20:50 +0100
    Re: What is the function of arch/x86/purgatory/purgatory.c? Larry Finger <Larry.Finger@lwfinger.net> - 2016-12-17 21:00 +0100

csiph-web