Re: [PATCH] scsi: esas2r: Fix format string type mistakes

From	Bart Van Assche <bart.vanassche@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: esas2r: Fix format string type mistakes
Date	2016-12-17 09:40 +0100
Message-ID	<sPiH7-7g6-7@gated-at.bofh.it> (permalink)
References	<sP8HL-FW-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/16/2016 10:50 PM, Kees Cook wrote:
> diff --git a/drivers/scsi/esas2r/esas2r_ioctl.c b/drivers/scsi/esas2r/esas2r_ioctl.c
> index 3e8483410f61..34976f9a1a10 100644
> --- a/drivers/scsi/esas2r/esas2r_ioctl.c
> +++ b/drivers/scsi/esas2r/esas2r_ioctl.c
> @@ -1301,7 +1301,7 @@ int esas2r_ioctl_handler(void *hostdata, int cmd, void __user *arg)
>  	ioctl = kzalloc(sizeof(struct atto_express_ioctl), GFP_KERNEL);
>  	if (ioctl == NULL) {
>  		esas2r_log(ESAS2R_LOG_WARN,
> -			   "ioctl_handler kzalloc failed for %d bytes",
> +			   "ioctl_handler kzalloc failed for %lu bytes",
>  			   sizeof(struct atto_express_ioctl));
>  		return -ENOMEM;
>  	}

Please use %zu to format size_t.

Bart.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: esas2r: Fix format string type mistakes Kees Cook <keescook@chromium.org> - 2016-12-16 23:00 +0100
  Re: [PATCH] scsi: esas2r: Fix format string type mistakes Bart Van Assche <bart.vanassche@gmail.com> - 2016-12-17 09:40 +0100

csiph-web