Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1543931
| From | Sam Ravnborg <sam@ravnborg.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 02/14] sparc64: add new fields to mmu context for shared context support |
| Date | 2016-12-17 08:40 +0100 |
| Message-ID | <sPhL3-6GL-5@gated-at.bofh.it> (permalink) |
| References | <sP5Ad-7fU-9@gated-at.bofh.it> <sP5Ad-7fU-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Mike
> diff --git a/arch/sparc/include/asm/mmu_context_64.h b/arch/sparc/include/asm/mmu_context_64.h
> index b84be67..d031799 100644
> --- a/arch/sparc/include/asm/mmu_context_64.h
> +++ b/arch/sparc/include/asm/mmu_context_64.h
> @@ -35,15 +35,15 @@ void __tsb_context_switch(unsigned long pgd_pa,
> static inline void tsb_context_switch(struct mm_struct *mm)
> {
> __tsb_context_switch(__pa(mm->pgd),
> - &mm->context.tsb_block[0],
> + &mm->context.tsb_block[MM_TSB_BASE],
> #if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE)
> - (mm->context.tsb_block[1].tsb ?
> - &mm->context.tsb_block[1] :
> + (mm->context.tsb_block[MM_TSB_HUGE].tsb ?
> + &mm->context.tsb_block[MM_TSB_HUGE] :
> NULL)
> #else
> NULL
> #endif
> - , __pa(&mm->context.tsb_descr[0]));
> + , __pa(&mm->context.tsb_descr[MM_TSB_BASE]));
> }
>
This is a nice cleanup that has nothing to do with your series.
Could you submit this as a separate patch so we can get it applied.
This is the only place left where the array index for tsb_block
and tsb_descr uses hardcoded values. And it would be good to get
rid of these.
Sam
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 02/14] sparc64: add new fields to mmu context for shared context support Mike Kravetz <mike.kravetz@oracle.com> - 2016-12-16 19:40 +0100
Re: [RFC PATCH 02/14] sparc64: add new fields to mmu context for shared context support Sam Ravnborg <sam@ravnborg.org> - 2016-12-17 08:40 +0100
Re: [RFC PATCH 02/14] sparc64: add new fields to mmu context for shared context support Mike Kravetz <mike.kravetz@oracle.com> - 2016-12-19 00:50 +0100
Re: [RFC PATCH 02/14] sparc64: add new fields to mmu context for shared context support Sam Ravnborg <sam@ravnborg.org> - 2016-12-21 19:20 +0100
Re: [RFC PATCH 02/14] sparc64: add new fields to mmu context for shared context support Sam Ravnborg <sam@ravnborg.org> - 2016-12-17 08:40 +0100
Re: [RFC PATCH 02/14] sparc64: add new fields to mmu context for shared context support Mike Kravetz <mike.kravetz@oracle.com> - 2016-12-19 00:40 +0100
Re: [RFC PATCH 02/14] sparc64: add new fields to mmu context for shared context support Sam Ravnborg <sam@ravnborg.org> - 2016-12-21 19:20 +0100
csiph-web