Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds

From	Nicolas Pitre <nicolas.pitre@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds
Date	2016-12-19 05:20 +0100
Message-ID	<sPXAB-2Qo-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <sP8HL-FW-3@gated-at.bofh.it> <sPIid-7in-3@gated-at.bofh.it> <sPKtI-s3-7@gated-at.bofh.it> <sPLg6-10W-31@gated-at.bofh.it> <sPTnj-8uZ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 18 Dec 2016, Russell King - ARM Linux wrote:

> On Sun, Dec 18, 2016 at 03:04:24PM +0000, Ard Biesheuvel wrote:
> > The only issue I spotted is that the kuser_get_tls routine has only
> > two instruction slots for the return sequence, but we can easily work
> > around that by moving the TLS hardware instruction around in the
> > template (and update the memcpy accordingly in kuser_init()
> 
> You can't actually - everything in this page is ABI, and moving
> that breaks the ABI.
> 
> One thing I'm toying with is splitting out the kuser helpers.  That
> means we can build it according to the configuration, and select the
> appropriate version at run time.  Work in progress.

That's the best solution indeed.  In fact there is already some runtime 
patching of the kuser page for how to retrieve the tls value in 
kuser_init().


Nicolas

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: disallow ARM_THUMB for ARMv4 builds Arnd Bergmann <arnd@arndb.de> - 2016-12-16 10:30 +0100
  Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-12-16 18:30 +0100
    Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds Arnd Bergmann <arnd@arndb.de> - 2016-12-16 23:00 +0100
      Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-12-18 13:00 +0100
        Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-12-18 15:20 +0100
          Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-12-18 16:10 +0100
            Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-12-19 00:50 +0100
              Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-12-19 05:20 +0100

csiph-web