Re: [PATCH] pci-error-recover: doc cleanup

From	Cao jin <caoj.fnst@cn.fujitsu.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pci-error-recover: doc cleanup
Date	2016-12-19 04:30 +0100
Message-ID	<sPWOd-2lp-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <sM7yy-75R-21@gated-at.bofh.it> <sM7Id-795-11@gated-at.bofh.it> <sMmQW-8h9-7@gated-at.bofh.it> <sMnah-8nx-3@gated-at.bofh.it> <sMuv7-4qd-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Sorry for late.

On 12/09/2016 10:37 PM, Jonathan Corbet wrote:
> On Fri, 9 Dec 2016 14:37:47 +0800
> Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> 
>> I am little confused too, even not sure if we are talking the same
>> *fatal error*, I am talking the fatal error defined in PCI Express spec,
>> chapter 6.2.2.2.1:
> 
> Therein lies my original discomfort with the change; it didn't seem to
> make sense to talk about recovering from a fatal error.  Perhaps making
> it "is done whenever a fatal error (as defined in section 6.2.2.2.1) has
> been detected that can be "solved" by resetting the link" or something
> like that to make it clear how the term is being used?
> 

I find that the .link_reset callback of struct pci_error_handlers isn't
called by anyone(if I didn't miss anything), and just a few drivers
implement this callback, and their implementation seems meaningless.

And the reset_link() provided by aer driver seems is a different thing
with .link_reset callback. So I am guessing this patch probably is not
quite suitable, and the doc maybe need update totally.

-- 
Sincerely,
Cao jin

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] pci-error-recover: doc cleanup Cao jin <caoj.fnst@cn.fujitsu.com> - 2016-12-19 04:30 +0100

csiph-web