Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1544267

linux-next: manual merge of the target-bva tree with Linus' tree

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Stephen Rothwell <sfr@canb.auug.org.au>
Newsgroups linux.kernel
Subject linux-next: manual merge of the target-bva tree with Linus' tree
Date Mon, 19 Dec 2016 02:30:01 +0100
Message-ID <sPUW5-16D-9@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201601; t=1482110930; bh=/PESvmRds29LnXYnyPhsSODv8eIUYZ51tUZZqk1ILwk=; h=Date:From:To:Cc:Subject:From; b=f18a9bHbAAP57VbkAp/M2i6fDlfVKiOuMQlGOVPTfdmu0HYzTYosOw8xWiSkEHpqX ii85QNVRhL2dji9Z+RNxTEGuNrNHkF9PNYLlK7FncUBY2XkTyGD1AwanokcSauLrkZ pgDO0bnrqBaF+CTK1I7vup0B+N1Slxh8wjbnyjic=
MIME-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 42
Organization linux.* mail to news gateway
X-Original-Cc linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
X-Original-Date Mon, 19 Dec 2016 12:28:50 +1100
X-Original-Message-ID <20161219122850.246a698e@canb.auug.org.au>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1544267

Show key headers only | View raw


Hi Bart,

Today's linux-next merge of the target-bva tree got a conflict in:

  drivers/target/target_core_configfs.c

between commit:

  450630975da9 ("don't open-code file_inode()")

from Linus' tree and commit:

  8cc3bb0789ea ("target: Use NULL instead of 0 to represent a pointer")

from the target-bva tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/target/target_core_configfs.c
index a35a347ec357,3bf6384c0f96..000000000000
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@@ -143,8 -143,8 +143,8 @@@ static ssize_t target_core_item_dbroot_
  		pr_err("db_root: cannot open: %s\n", db_root_stage);
  		return -EINVAL;
  	}
 -	if (!S_ISDIR(fp->f_inode->i_mode)) {
 +	if (!S_ISDIR(file_inode(fp)->i_mode)) {
- 		filp_close(fp, 0);
+ 		filp_close(fp, NULL);
  		mutex_unlock(&g_tf_lock);
  		pr_err("db_root: not a directory: %s\n", db_root_stage);
  		return -EINVAL;

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

linux-next: manual merge of the target-bva tree with Linus' tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-12-19 02:30 +0100

csiph-web