Re: [PATCH -v4 02/10] futex: Add missing error handling to FUTEX_REQUEUE_PI

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH -v4 02/10] futex: Add missing error handling to FUTEX_REQUEUE_PI
Date	2016-12-19 00:40 +0100
Message-ID	<sPTdE-8rg-33@gated-at.bofh.it> (permalink)
References	<sNRfX-7LI-3@gated-at.bofh.it> <sNRfY-7LI-35@gated-at.bofh.it> <sPaJA-282-3@gated-at.bofh.it> <sPnGO-1Ui-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Dec 17, 2016 at 02:54:11PM +0100, Peter Zijlstra wrote:
> On Fri, Dec 16, 2016 at 04:06:39PM -0800, Darren Hart wrote:
> > On Tue, Dec 13, 2016 at 09:36:40AM +0100, Peter Zijlstra wrote:
> > > Thomas spotted that fixup_pi_state_owner() can return errors and we
> > > fail to unlock the rt_mutex in that case.
> > > 
> > 
> > We handled this explicitly before Patch 1/10, so can this be rolled into 1/10
> > (er 9) as a single commit?
> 
> I don't think we did, see how this branch doesn't set pi_mutex.
> 

So it is, I stand corrected. So for 2/10 also then:

Reviewed-by: Darren Hart <dvhart@linux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -v4 02/10] futex: Add missing error handling to FUTEX_REQUEUE_PI Peter Zijlstra <peterz@infradead.org> - 2016-12-13 10:10 +0100
  Re: [PATCH -v4 02/10] futex: Add missing error handling to  FUTEX_REQUEUE_PI Darren Hart <dvhart@infradead.org> - 2016-12-17 01:10 +0100
    Re: [PATCH -v4 02/10] futex: Add missing error handling to  FUTEX_REQUEUE_PI Peter Zijlstra <peterz@infradead.org> - 2016-12-17 15:00 +0100
      Re: [PATCH -v4 02/10] futex: Add missing error handling to  FUTEX_REQUEUE_PI Darren Hart <dvhart@infradead.org> - 2016-12-19 00:40 +0100

csiph-web