Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1544165

Re: ipc: BUG: sem_unlock unlocks non-locked lock

Show all headers | View raw

On Fri, 16 Dec 2016, Dmitry Vyukov wrote:

>[ BUG: bad unlock balance detected! ]
>4.9.0+ #89 Not tainted

Thanks for the report, I can reproduce the issue as of (which I obviously
should have tested with lockdep):

370b262c896 (ipc/sem: avoid idr tree lookup for interrupted semop)

I need to think more about it this evening, but I believe the issue to be
the potentially bogus locknum in the unlock path, as we are calling sem_lock
without updating the variable. I'll send a patch after more testing. This
fixes it for me:

diff --git a/ipc/sem.c b/ipc/sem.c
index e08b94851922..fba6139e7208 100644
--- a/ipc/sem.c
+++ b/ipc/sem.c
@@ -1977,7 +1977,7 @@ SYSCALL_DEFINE4(semtimedop, int, semid, struct sembuf __user *, tsops,
 		}
 
 		rcu_read_lock();
-		sem_lock(sma, sops, nsops);
+	        sem_lock(sma, sops, nsops);
 
 		if (!ipc_valid_object(&sma->sem_perm))
 			goto out_unlock_free;

Thanks,
Davidlohr

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

ipc: BUG: sem_unlock unlocks non-locked lock Dmitry Vyukov <dvyukov@google.com> - 2016-12-16 10:40 +0100
  Re: ipc: BUG: sem_unlock unlocks non-locked lock Davidlohr Bueso <dave@stgolabs.net> - 2016-12-18 17:30 +0100
    Re: ipc: BUG: sem_unlock unlocks non-locked lock Davidlohr Bueso <dave@stgolabs.net> - 2016-12-18 17:40 +0100
      Re: ipc: BUG: sem_unlock unlocks non-locked lock Manfred Spraul <manfred@colorfullife.com> - 2016-12-18 19:40 +0100
        [PATCH v2] ipc/sem.c: fix incorrect sem_lock pairing Manfred Spraul <manfred@colorfullife.com> - 2016-12-20 07:40 +0100

csiph-web