Re: [GIT PULL] kbuild changes for v4.9-rc1

From	Jiri Slaby <jslaby@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] kbuild changes for v4.9-rc1
Date	2016-12-18 16:10 +0100
Message-ID	<sPLg6-10W-55@gated-at.bofh.it> (permalink)
References	(7 earlier) <sPHct-6Eg-5@gated-at.bofh.it> <sPHvQ-70q-5@gated-at.bofh.it> <sPJHk-8l3-7@gated-at.bofh.it> <sPKWJ-C5-9@gated-at.bofh.it> <sPL6p-Fz-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/18/2016, 03:54 PM, Nikolay Borisov wrote:
> 
> 
> On 18.12.2016 16:45, Jiri Slaby wrote:
>> Moreover, with some modules, __put_user_1 and others are reported
>> instead of mcount.
> 
> 
> nm vmlinux | grep __fentry__
> nm vmlinux | grep mcount
> 
> What do these report ? I bet you that in your vmlinux the first one
> would return something like :
> 
> ffffffff822f1810 T __fentry__
> ffffffff827fdc20 r __kcrctab___fentry__
> ffffffff82809461 r __kstrtab___fentry__
> ffffffff827e6c20 R __ksymtab___fentry__
>  and nothing for the second. Whereas doing nm on the module in question
> would give nothing for __fentry__ and something like: U mcount

Well, I have just won a beer:
$ nm vmlinux | grep mcount
         w __crc_mcount
c0b3bd34 r __kcrctab_mcount
c0b41692 r __kstrtab_mcount
c0b2dd04 R __ksymtab_mcount
c0896130 T mcount
c0c9ee20 T __start_mcount_loc
c0cba89c T __stop_mcount_loc
$ nm vmlinux | grep __fentry__
$ nm sound/soundcore.ko | grep mcount
         U mcount

No, I am really not stupid. We compile the kernels like this for over a
decade and it really broke with 4.9. Applying the patch fixes the
problem. Reverting it, makes it recur.

regards,
-- 
js
suse labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [GIT PULL] kbuild changes for v4.9-rc1 Jiri Slaby <jslaby@suse.cz> - 2016-12-16 21:00 +0100
  Re: [GIT PULL] kbuild changes for v4.9-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-16 21:00 +0100
    Re: [GIT PULL] kbuild changes for v4.9-rc1 Jiri Slaby <jslaby@suse.cz> - 2016-12-17 10:00 +0100
      Re: [GIT PULL] kbuild changes for v4.9-rc1 Adam Borowski <kilobyte@angband.pl> - 2016-12-17 10:40 +0100
      Re: [GIT PULL] kbuild changes for v4.9-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-18 01:00 +0100
        Re: [GIT PULL] kbuild changes for v4.9-rc1 Jiri Slaby <jslaby@suse.cz> - 2016-12-18 11:50 +0100
          Re: [GIT PULL] kbuild changes for v4.9-rc1 Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-12-18 12:10 +0100
            Re: [GIT PULL] kbuild changes for v4.9-rc1 Nikolay Borisov <n.borisov.lkml@gmail.com> - 2016-12-18 14:30 +0100
              Re: [GIT PULL] kbuild changes for v4.9-rc1 Jiri Slaby <jslaby@suse.cz> - 2016-12-18 15:50 +0100
                Re: [GIT PULL] kbuild changes for v4.9-rc1 Nikolay Borisov <n.borisov.lkml@gmail.com> - 2016-12-18 16:00 +0100
                Re: [GIT PULL] kbuild changes for v4.9-rc1 Jiri Slaby <jslaby@suse.cz> - 2016-12-18 16:10 +0100

csiph-web