Re: [PATCH v5 2/6] [media] rc-main: split setup and unregister functions

From	Andi Shyti <andi.shyti@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/6] [media] rc-main: split setup and unregister functions
Date	2016-12-18 10:10 +0100
Message-ID	<sPFDH-5K9-15@gated-at.bofh.it> (permalink)
References	<sOU25-8aq-3@gated-at.bofh.it> <sOU26-8aq-13@gated-at.bofh.it> <sOZEt-3tv-9@gated-at.bofh.it> <sPFDH-5K9-17@gated-at.bofh.it> <sP1wC-4Nh-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Sean,

> On Fri, Dec 16, 2016 at 12:10:26PM +0000, Sean Young wrote:
> > Sorry to add to your woes, but there are some checkpatch warnings and
> > errors. Please can you correct these. One is below.
> 
> Actually, the changes are pretty minor, I can fix them up before sending
> them to Mauro. Sorry for bothering you.

yes, it's an error on the previous code:

ERROR: do not initialise statics to false
#109: FILE: drivers/media/rc/rc-main.c:1521:
+       static bool raw_init = false; /* raw decoders loaded? */

total: 1 errors, 0 warnings, 196 lines checked

I noticed this already before, but I preferred to leave it
in its original status.

No worries, if you want I will send the fix, it's indeed quite
an easy fix.

Thanks,
Andi

Thread

[PATCH v5 0/6] Add support for IR transmitters Andi Shyti <andi.shyti@samsung.com> - 2016-12-16 07:20 +0100
  [PATCH v5 2/6] [media] rc-main: split setup and unregister functions Andi Shyti <andi.shyti@samsung.com> - 2016-12-16 07:20 +0100
    Re: [PATCH v5 2/6] [media] rc-main: split setup and unregister  functions Sean Young <sean@mess.org> - 2016-12-16 13:20 +0100
      Re: [PATCH v5 2/6] [media] rc-main: split setup and unregister  functions Sean Young <sean@mess.org> - 2016-12-16 15:20 +0100
        Re: [PATCH v5 2/6] [media] rc-main: split setup and unregister  functions Andi Shyti <andi.shyti@samsung.com> - 2016-12-18 10:10 +0100
  [PATCH v5 1/6] [media] rc-main: assign driver type during allocation Andi Shyti <andi.shyti@samsung.com> - 2016-12-16 07:20 +0100
    Re: [PATCH v5 1/6] [media] rc-main: assign driver type during  allocation kbuild test robot <lkp@intel.com> - 2016-12-16 09:00 +0100
    [PATCH v6 1/6] [media] rc-main: assign driver type during allocation Andi Shyti <andi.shyti@samsung.com> - 2016-12-16 10:00 +0100
  [PATCH v5 3/6] [media] rc-core: add support for IR raw transmitters Andi Shyti <andi.shyti@samsung.com> - 2016-12-16 07:20 +0100
    Re: [PATCH v5 3/6] [media] rc-core: add support for IR raw  transmitters kbuild test robot <lkp@intel.com> - 2016-12-16 12:50 +0100

csiph-web