Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543809

Re: [PATCH] acpi: Fix format string type mistakes

From "Rafael J. Wysocki" <rafael@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] acpi: Fix format string type mistakes
Date 2016-12-16 23:40 +0100
Message-ID <sP9ku-184-25@gated-at.bofh.it> (permalink)
References <sP8HL-FW-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook <keescook@chromium.org> wrote:
> From: Emese Revfy <re.emese@gmail.com>
>
> This adds the missing __printf attribute which allows compile time
> format string checking (and will be used by the coming initify gcc
> plugin). Additionally, this fixes the warnings exposed by the attribute.
>
> Signed-off-by: Emese Revfy <re.emese@gmail.com>
> [kees: split scsi/acpi, merged attr and fix, new commit messages]
> Signed-off-by: Kees Cook <keescook@chromium.org>

This modifies code that we get from an external projiect (ACPICA) and
the bugs should be fixed in there in the first place.

Moreover, I'm not sure if adding __printf in acpiosxf.h is a good idea.

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] acpi: Fix format string type mistakes Kees Cook <keescook@chromium.org> - 2016-12-16 23:00 +0100
  Re: [PATCH] acpi: Fix format string type mistakes "Rafael J. Wysocki" <rafael@kernel.org> - 2016-12-16 23:40 +0100
    Re: [PATCH] acpi: Fix format string type mistakes Kees Cook <keescook@chromium.org> - 2016-12-17 00:10 +0100
      Re: [PATCH] acpi: Fix format string type mistakes "Rafael J. Wysocki" <rafael@kernel.org> - 2016-12-17 03:20 +0100
      RE: [PATCH] acpi: Fix format string type mistakes "Moore, Robert" <robert.moore@intel.com> - 2016-12-19 22:50 +0100
  RE: [PATCH] acpi: Fix format string type mistakes "Zheng, Lv" <lv.zheng@intel.com> - 2016-12-19 07:10 +0100
    RE: [PATCH] acpi: Fix format string type mistakes "Zheng, Lv" <lv.zheng@intel.com> - 2016-12-21 08:40 +0100
      RE: [PATCH] acpi: Fix format string type mistakes "Zheng, Lv" <lv.zheng@intel.com> - 2016-12-21 09:10 +0100
        RE: [PATCH] acpi: Fix format string type mistakes "Moore, Robert" <robert.moore@intel.com> - 2016-12-21 18:20 +0100
          RE: [PATCH] acpi: Fix format string type mistakes "Zheng, Lv" <lv.zheng@intel.com> - 2016-12-22 08:00 +0100

csiph-web